From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org, Arjen Laarhoven <arjen@yaph.org>,
Jeff King <peff@peff.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
"Mike Ralphson" <mike@abacus.co.uk>
Subject: Re: What's in git.git (Oct 2008, #03; Tue, 14)
Date: Wed, 15 Oct 2008 12:38:56 -0700 [thread overview]
Message-ID: <7vljwpr6lr.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <bsftmRx17krWBpVlulipoJEO1fWsD0hZfF3HOZcajX6GV66RKW8W6A@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Wed, 15 Oct 2008 10:35:30 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Two questions:
>
> 1) Should a5a5a048 be in maint?
> "xdiff-interface.c: strip newline (and cr) from line before pattern matching"
I would have forked a maint-fix topic to prepare a merge of this fix to
both 'maint' and 'master' but apparently this was applied directly on
'master'. I may be missing a valid reason why Shawn did it this way.
If we can add a test case to demonstrate the existing breakage, I think we
can (and should) cherry-pick it to 'maint'.
> 2) Do we want to stick with compat/regex on
>
> Darwin: Arjen
> FreeBSD: Jeff
> AIX: Mike
>
> now that the builtin funcname patterns have been converted to Extended
> Regular Expressions?
Mike already said AIX does not need to, and I expect others would say
their native regexp library can grok ERE just fine. Let's wait for others
to confirm and then remove the compat/regex thing.
next prev parent reply other threads:[~2008-10-15 19:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 22:08 What's in git.git (Oct 2008, #03; Tue, 14) Junio C Hamano
2008-10-15 15:35 ` Brandon Casey
2008-10-15 17:25 ` Mike Ralphson
2008-10-15 19:38 ` Junio C Hamano [this message]
2008-10-15 20:20 ` Shawn O. Pearce
2008-10-15 20:26 ` Junio C Hamano
2008-10-15 20:36 ` Shawn O. Pearce
2008-10-16 0:58 ` [PATCH maint 1/2] t4018-diff-funcname: rework negated last expression test drafnel
[not found] ` <1224118730-24711-1-git-send-email-drafnel@gmail.com>
2008-10-16 0:58 ` [PATCH maint 2/2] t4018-diff-funcname: demonstrate end of line funcname matching flaw drafnel
2008-10-16 10:08 ` What's in git.git (Oct 2008, #03; Tue, 14) Jeff King
2008-10-16 15:21 ` Brandon Casey
2008-10-16 15:37 ` Pieter de Bie
2008-10-17 7:02 ` Arjen Laarhoven
2008-10-24 2:44 ` Junio C Hamano
2008-10-17 9:53 ` Jeff King
2008-10-17 23:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vljwpr6lr.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=arjen@yaph.org \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=mike@abacus.co.uk \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.