From: Junio C Hamano <gitster@pobox.com>
To: "W. Trevor King" <wking@tremily.us>
Cc: Git <git@vger.kernel.org>, Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH v2] Documentation/githooks: Explain pre-rebase parameters
Date: Sat, 23 Feb 2013 13:21:59 -0800 [thread overview]
Message-ID: <7vobfa7mko.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <c8b19dc074a81b009399ff1011102737761658ec.1361633106.git.wking@tremily.us> (W. Trevor King's message of "Sat, 23 Feb 2013 10:27:39 -0500")
"W. Trevor King" <wking@tremily.us> writes:
> +This hook is called by 'git rebase' and can be used to prevent a
> +branch from getting rebased. The hook takes two parameters: the
> +upstream the series was forked from and the branch being rebased. The
> +second parameter will be missing when rebasing the current branch.
takes one or two parameters?
Other than that, looks good to me, but it took me two readings to
notice where these two parameters are described. I have a feeling
that a comma s/forked from and/forked from, and/; might make them a
bit more spottable, but others may have better suggestions to make
them stand out more.
Thanks, will queue.
>
> post-checkout
> ~~~~~~~~~~~~~
next prev parent reply other threads:[~2013-02-23 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 11:03 [PATCH] Documentation/githooks: Explain pre-rebase parameters W. Trevor King
2013-02-19 13:17 ` Thomas Rast
2013-02-19 13:23 ` W. Trevor King
2013-02-19 17:05 ` Junio C Hamano
2013-02-19 19:08 ` Junio C Hamano
2013-02-20 16:36 ` W. Trevor King
2013-02-20 17:23 ` Junio C Hamano
2013-02-23 15:27 ` [PATCH v2] " W. Trevor King
2013-02-23 21:21 ` Junio C Hamano [this message]
2013-02-23 21:35 ` W. Trevor King
2013-02-24 8:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vobfa7mko.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.