From: Junio C Hamano <gitster@pobox.com>
To: "W. Trevor King" <wking@tremily.us>
Cc: Git <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation/githooks: Explain pre-rebase parameters
Date: Wed, 20 Feb 2013 09:23:57 -0800 [thread overview]
Message-ID: <7vwqu2yk42.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130220163621.GI14102@odin.tremily.us> (W. Trevor King's message of "Wed, 20 Feb 2013 11:36:21 -0500")
"W. Trevor King" <wking@tremily.us> writes:
> Since $upstream_arg will always be set, would it make sense to change
> the `${1+"$@"}` syntax in run_pre_rebase_hook() to a plain "$@"?
I suspect that there no longer is a need for ${1+"$@"} in today's
world even when you do not have arguments, and it certainly is fine
if you want to update that particular instance in the function with
a single caller that calls it with 1 or 2 arguments, especially if
you are updating the code in the vicinity.
I however do not think it is worth blindly replacing them tree-wide
just for the sake of changing them. The upside of helping beginning
shell programers by possibly better readability does not look great,
compared to the downside of possibly breaking somebody who is still
on a broken shell that the old idiom is still helping.
next prev parent reply other threads:[~2013-02-20 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 11:03 [PATCH] Documentation/githooks: Explain pre-rebase parameters W. Trevor King
2013-02-19 13:17 ` Thomas Rast
2013-02-19 13:23 ` W. Trevor King
2013-02-19 17:05 ` Junio C Hamano
2013-02-19 19:08 ` Junio C Hamano
2013-02-20 16:36 ` W. Trevor King
2013-02-20 17:23 ` Junio C Hamano [this message]
2013-02-23 15:27 ` [PATCH v2] " W. Trevor King
2013-02-23 21:21 ` Junio C Hamano
2013-02-23 21:35 ` W. Trevor King
2013-02-24 8:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqu2yk42.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.