All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Gerrit Pape <pape@smarden.org>,
	git@vger.kernel.org, Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH] Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion.
Date: Mon, 07 May 2007 18:42:49 -0700	[thread overview]
Message-ID: <7vr6ps5bvq.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070508013532.GA11311@spearce.org> (Shawn O. Pearce's message of "Mon, 7 May 2007 21:35:32 -0400")

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Gerrit's patch to try and use COMMIT_MSG feels wrong to me, as
> git-commit overwrites that file with what it gets from its "input".

Yes.

> I agree my patch steps us further from a "git whatnow", but we're
> already in deep with MERGE_MSG.  We might as well keep that existing
> convention that it can be used to prep the commit message for the
> next git-commit invocation, and record other data somehow for the
> "git whatnow" case.

Fair enough.

  reply	other threads:[~2007-05-08  1:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-04 14:30 [PATCH] git-commit -f <file>: take message from file, and remove file upon completion Gerrit Pape
2007-05-04 14:32 ` [PATCH] Have git-revert, git-cherry-pick cleanup ./.msg upon successful completion Gerrit Pape
2007-05-04 15:28   ` Alex Riesen
2007-05-05  3:46   ` Shawn O. Pearce
2007-05-06  6:49     ` Junio C Hamano
2007-05-08  1:35       ` Shawn O. Pearce
2007-05-08  1:42         ` Junio C Hamano [this message]
2007-05-07  7:46     ` Gerrit Pape
2007-05-07 10:53   ` [PATCH] Have git-revert, git-cherry-pick use $GIT_DIR/COMMIT_MSG instead of ./.msg Gerrit Pape
2007-05-07 10:54     ` [PATCH] git-commit: fix usage to show (-F|-f) <logfile> Gerrit Pape

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr6ps5bvq.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=pape@smarden.org \
    --cc=raa.lkml@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.