All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Štěpán Němec" <stepnem@gmail.com>,
	"Petr Onderka" <gsvick@gmail.com>,
	git@vger.kernel.org, "Henrik Grubbstrm" <grubba@grubba.org>
Subject: Re: [PATCH v2] Add global and system-wide gitattributes
Date: Sun, 29 Aug 2010 22:34:40 -0700	[thread overview]
Message-ID: <7vy6bohde7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqbp8mskv1.fsf@bauges.imag.fr> (Matthieu Moy's message of "Sat\, 28 Aug 2010 19\:33\:22 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Štěpán Němec <stepnem@gmail.com> writes:
>
>> Petr Onderka <gsvick@gmail.com> writes:
>>
>>> Allow gitattributes to be set globally and system wide. This way, settings
>>> for particular file types can be set in one place and apply for all user's
>>> repositories.
>>
>> [...]
>>
>> I really can't wait till this gets into Git and I'm certainly not the
>> only one (thank you so much for working on it, Petr!).
>
> Same here ;-).
>
>> Any reason the patch still hasn't been applied?
>
> Usually, patches are applied if either
>
> 1) Junio has personal interest in it, or
>
> 2) Other people review the code and show interest for it.

(1) is a bit more subtle than that.  Even when I do not foresee using a
proposed feature myself, if I can imagine somebody else would benefit, and
more importantly if I can see a healthy rationale behind the change so
that I can convince myself to be an advocate of that change to the end
users, such a change will fall into category (1).  That is why I often ask
people to justify their changes better than they originally do.

Isn't the patch in question on 'pu' to be tried by interested parties
already?

  reply	other threads:[~2010-08-30  5:35 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11  1:04 [PATCH/RFC] Add global and system-wide gitattributes Petr Onderka
2010-08-11  9:20 ` Henrik Grubbström
2010-08-11 10:50   ` Petr Onderka
2010-08-11 12:31 ` Matthieu Moy
2010-08-11 22:19 ` Junio C Hamano
2010-08-16 16:51   ` Petr Onderka
2010-08-16 16:56     ` [PATCH v2] " Petr Onderka
2010-08-25  9:55       ` Štěpán Němec
2010-08-28 17:33         ` Matthieu Moy
2010-08-30  5:34           ` Junio C Hamano [this message]
2010-08-30  9:09             ` Štěpán Němec
2010-08-28 18:35       ` Matthieu Moy
2010-08-28 18:41         ` [PATCH] core.attributesfile: a fix, a simplification, and a test Matthieu Moy
2010-08-29 10:32           ` [PATCH v3?] Add global and system-wide gitattributes Štěpán Němec
2010-08-30  8:04             ` Junio C Hamano
2010-08-30  8:26               ` Matthieu Moy
2010-08-30 20:47                 ` Junio C Hamano
2010-08-30 21:11                   ` Junio C Hamano
2010-08-30 22:55                     ` Matthieu Moy
2010-08-30 23:15                       ` [PATCH 1/3 v2] tests: factor HOME=$(pwd) in test-lib.sh Matthieu Moy
2010-08-31  7:42                         ` Ævar Arnfjörð Bjarmason
2010-09-01  7:56                           ` Ævar Arnfjörð Bjarmason
2010-09-01 15:24                             ` Junio C Hamano
2010-09-01 15:40                               ` Ævar Arnfjörð Bjarmason
2010-09-01 16:57                                 ` Matthieu Moy
2010-08-30 23:15                       ` [PATCH 2/3] don't write to git_log_output_encoding outside git_config() Matthieu Moy
2010-09-02  8:56                         ` Matthieu Moy
2010-09-02 15:49                           ` Junio C Hamano
2010-08-30 23:15                       ` [PATCH 3/3 v4] Add global and system-wide gitattributes Matthieu Moy
2010-08-31 22:41                         ` Matthieu Moy
2010-08-31 22:42                           ` [PATCH] " Matthieu Moy
2010-08-31 23:56                           ` [PATCH 3/3 v4] " Junio C Hamano
2010-08-30  9:50               ` [PATCH] tests: factor HOME=$(pwd) in test-lib.sh Matthieu Moy
2010-08-30 10:22                 ` Ævar Arnfjörð Bjarmason
2010-08-30 10:54                   ` Matthieu Moy
2010-08-30 11:08                     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy6bohde7.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=grubba@grubba.org \
    --cc=gsvick@gmail.com \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.