From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Petr Onderka <gsvick@gmail.com>
Subject: Re: [PATCH 3/3 v4] Add global and system-wide gitattributes
Date: Wed, 01 Sep 2010 00:41:11 +0200 [thread overview]
Message-ID: <vpqbp8i2yns.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1283210123-19752-3-git-send-email-Matthieu.Moy@imag.fr> (Matthieu Moy's message of "Tue\, 31 Aug 2010 01\:15\:23 +0200")
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> This version doesn't touch config.c, and calls git_config with a
> trivial callback reading only the core.attributesfile variable.
I see that pu has a variant of my fix:
17cd572 fixup! Add global and system-wide gitattributes
(is the fixup! here on purpose, or is it a failed rebase -i?)
Junio: your fixup fixes the git_config issue, but doesn't have the
test that my patch have. The difference is that your fixup moves the
global variable attributes_file in attr.c, which sounds like a good
idea. I'm resending my patch with this change for conveinience.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-08-31 22:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 1:04 [PATCH/RFC] Add global and system-wide gitattributes Petr Onderka
2010-08-11 9:20 ` Henrik Grubbström
2010-08-11 10:50 ` Petr Onderka
2010-08-11 12:31 ` Matthieu Moy
2010-08-11 22:19 ` Junio C Hamano
2010-08-16 16:51 ` Petr Onderka
2010-08-16 16:56 ` [PATCH v2] " Petr Onderka
2010-08-25 9:55 ` Štěpán Němec
2010-08-28 17:33 ` Matthieu Moy
2010-08-30 5:34 ` Junio C Hamano
2010-08-30 9:09 ` Štěpán Němec
2010-08-28 18:35 ` Matthieu Moy
2010-08-28 18:41 ` [PATCH] core.attributesfile: a fix, a simplification, and a test Matthieu Moy
2010-08-29 10:32 ` [PATCH v3?] Add global and system-wide gitattributes Štěpán Němec
2010-08-30 8:04 ` Junio C Hamano
2010-08-30 8:26 ` Matthieu Moy
2010-08-30 20:47 ` Junio C Hamano
2010-08-30 21:11 ` Junio C Hamano
2010-08-30 22:55 ` Matthieu Moy
2010-08-30 23:15 ` [PATCH 1/3 v2] tests: factor HOME=$(pwd) in test-lib.sh Matthieu Moy
2010-08-31 7:42 ` Ævar Arnfjörð Bjarmason
2010-09-01 7:56 ` Ævar Arnfjörð Bjarmason
2010-09-01 15:24 ` Junio C Hamano
2010-09-01 15:40 ` Ævar Arnfjörð Bjarmason
2010-09-01 16:57 ` Matthieu Moy
2010-08-30 23:15 ` [PATCH 2/3] don't write to git_log_output_encoding outside git_config() Matthieu Moy
2010-09-02 8:56 ` Matthieu Moy
2010-09-02 15:49 ` Junio C Hamano
2010-08-30 23:15 ` [PATCH 3/3 v4] Add global and system-wide gitattributes Matthieu Moy
2010-08-31 22:41 ` Matthieu Moy [this message]
2010-08-31 22:42 ` [PATCH] " Matthieu Moy
2010-08-31 23:56 ` [PATCH 3/3 v4] " Junio C Hamano
2010-08-30 9:50 ` [PATCH] tests: factor HOME=$(pwd) in test-lib.sh Matthieu Moy
2010-08-30 10:22 ` Ævar Arnfjörð Bjarmason
2010-08-30 10:54 ` Matthieu Moy
2010-08-30 11:08 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqbp8i2yns.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gsvick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.