[PATCH] platform/x86/intel/pmt: Fix kobject memory leak on init failure

[PATCH] platform/x86/intel/pmt: Fix kobject memory leak on init failure

[Kaushlendra Kumar]

When kobject_init_and_add() fails in pmt_features_discovery(), the
function returns without calling kobject_put(). This violates the
kobject API contract where kobject_put() must be called even on
initialization failure to properly release allocated resources.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
 drivers/platform/x86/intel/pmt/discovery.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/pmt/discovery.c b/drivers/platform/x86/intel/pmt/discovery.c
index 32713a194a55..9c5b4d0e1fae 100644
--- a/drivers/platform/x86/intel/pmt/discovery.c
+++ b/drivers/platform/x86/intel/pmt/discovery.c
@@ -503,8 +503,10 @@ static int pmt_features_discovery(struct pmt_features_priv *priv,
 
 	ret = kobject_init_and_add(&feature->kobj, ktype, &priv->dev->kobj,
 				   "%s", pmt_feature_names[feature->id]);
-	if (ret)
+	if (ret) {
+		kobject_put(&feature->kobj);
 		return ret;
+	}
 
 	kobject_uevent(&feature->kobj, KOBJ_ADD);
 	pmt_features_add_feat(feature);
-- 
2.34.1

Re: [PATCH] platform/x86/intel/pmt: Fix kobject memory leak on init failure

[Ilpo Järvinen]

On Tue, 23 Dec 2025, Kaushlendra Kumar wrote:

> When kobject_init_and_add() fails in pmt_features_discovery(), the
> function returns without calling kobject_put(). This violates the
> kobject API contract where kobject_put() must be called even on
> initialization failure to properly release allocated resources.
> 
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>

Hi,

Thanks, I've applied this to the review-ilpo-fixes branch but I had to add 
Fixes tag myself as your submission did not contain one. In the future, 
when fixing an issue, please add a Fixes tag pointing to the commit that 
introduced the problem.

> ---
>  drivers/platform/x86/intel/pmt/discovery.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/pmt/discovery.c b/drivers/platform/x86/intel/pmt/discovery.c
> index 32713a194a55..9c5b4d0e1fae 100644
> --- a/drivers/platform/x86/intel/pmt/discovery.c
> +++ b/drivers/platform/x86/intel/pmt/discovery.c
> @@ -503,8 +503,10 @@ static int pmt_features_discovery(struct pmt_features_priv *priv,
>  
>  	ret = kobject_init_and_add(&feature->kobj, ktype, &priv->dev->kobj,
>  				   "%s", pmt_feature_names[feature->id]);
> -	if (ret)
> +	if (ret) {
> +		kobject_put(&feature->kobj);
>  		return ret;
> +	}
>  
>  	kobject_uevent(&feature->kobj, KOBJ_ADD);
>  	pmt_features_add_feat(feature);


-- 
 i.

RE: [PATCH] platform/x86/intel/pmt: Fix kobject memory leak on init failure

[Kumar, Kaushlendra]

On Tue, 23 Dec 2025, Ilpo Järvinen wrote:

> Hi,
> 
> Thanks, I've applied this to the review-ilpo-fixes branch but I had to add 
> Fixes tag myself as your submission did not contain one. In the future, 
> when fixing an issue, please add a Fixes tag pointing to the commit that 
> introduced the problem.

Hi Ilpo,

Thank you for applying the patch and adding the Fixes tag. I'll ensure to 
include it in future submissions.

Thanks,
Kaushlendra