From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>, linux-mtd@lists.infradead.org
Cc: Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA
Date: Fri, 21 Feb 2014 21:27:27 +0100 [thread overview]
Message-ID: <8022927.N4UoME29Ho@avalon> (raw)
In-Reply-To: <1393012474-22399-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
Thank you for the patch.
On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 90ff447bf043..e7786913280a 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -458,6 +458,7 @@ config MTD_NAND_MXC
>
> config MTD_NAND_SH_FLCTL
> tristate "Support for NAND on Renesas SuperH FLCTL"
> + depends on HAS_DMA
> depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> help
> Several Renesas SuperH CPU has FLCTL. This option enables support
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>, linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA
Date: Fri, 21 Feb 2014 21:27:27 +0100 [thread overview]
Message-ID: <8022927.N4UoME29Ho@avalon> (raw)
In-Reply-To: <1393012474-22399-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
Thank you for the patch.
On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 90ff447bf043..e7786913280a 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -458,6 +458,7 @@ config MTD_NAND_MXC
>
> config MTD_NAND_SH_FLCTL
> tristate "Support for NAND on Renesas SuperH FLCTL"
> + depends on HAS_DMA
> depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> help
> Several Renesas SuperH CPU has FLCTL. This option enables support
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-02-21 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 19:54 [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA Geert Uytterhoeven
2014-02-21 19:54 ` Geert Uytterhoeven
2014-02-21 20:27 ` Laurent Pinchart [this message]
2014-02-21 20:27 ` Laurent Pinchart
2014-02-21 20:49 ` Brian Norris
2014-02-21 20:49 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8022927.N4UoME29Ho@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.