Re: [PATCH can-next v5 03/20] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces

From: "Heiko Stübner" <heiko@sntech.de>
To: kernel@pengutronix.de, Alibek Omarov <a1ba.omarov@gmail.com>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Elaine Zhang <zhangqing@rock-chips.com>,
	David Jander <david.jander@protonic.nl>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Simon Horman <horms@kernel.org>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	David Jander <david@protonic.nl>
Subject: Re: [PATCH can-next v5 03/20] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces
Date: Wed, 04 Sep 2024 10:52:54 +0200	[thread overview]
Message-ID: <8027881.qOBuL9xsDt@diego> (raw)
In-Reply-To: <20240904-rockchip-canfd-v5-3-8ae22bcb27cc@pengutronix.de>

Am Mittwoch, 4. September 2024, 10:12:47 CEST schrieb Marc Kleine-Budde:
> From: David Jander <david@protonic.nl>
> 
> This patch adds support for the CAN0 and CAN1 interfaces to the board.
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Tested-by: Alibek Omarov <a1ba.omarov@gmail.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts b/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts
> index c2dfffc638d1..052ef03694cf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts
> @@ -117,6 +117,20 @@ &cpu3 {
>  	cpu-supply = <&vdd_cpu>;
>  };
>  
> +&can0 {
> +	compatible = "rockchip,rk3568v3-canfd", "rockchip,rk3568v2-canfd";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&can0m0_pins>;
> +	status = "okay";
> +};
> +
> +&can1 {
> +	compatible = "rockchip,rk3568v3-canfd", "rockchip,rk3568v2-canfd";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&can1m1_pins>;
> +	status = "okay";
> +};
> +

cpu3 > can0 ... aka alphabetical sorting of phandles

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

No need to resend for that though.

>  &gmac1 {
>  	assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
>  	assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru CLK_MAC1_2TOP>;
> 
> 