From: Nicolai Buchwitz <nb@tipi-net.de>
To: netdev-bot+sashiko@kernel.org
Cc: andrew@lunn.ch, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
kory.maincent@bootlin.com, vadim.fedorenko@linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider
Date: Fri, 25 Sep 2026 11:15:02 +0200 [thread overview]
Message-ID: <802cc23e2050dfbe56b7564b921e06ad@tipi-net.de> (raw)
In-Reply-To: <179025240309.2160803.13124415103175394580@kernel.org>
On 24.9.2026 14:20, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let
> patchwork
> know by including "pw-bot: cr" as a separate line at the end of your
> reply
> (one such reply per series is enough).
>
> - [Medium] ethnl_set_tsconfig() can now install an
> HWTSTAMP_SOURCE_NETDEV
> provider on a device that has no hwtstamp NDOs, and that provider
> can…
> - [Low] The new TSCONFIG_SET gate in ethnl_set_tsconfig()
> (tsconfig.c:303-305) looks only at whether dev->phydev is the
> default…
>
> --
> [...]
> [Severity: Medium]
>
> The commit message says "this makes a netdev provider reachable without
> ndo_hwtstamp_get". Should a netdev provider be reachable at all on a
> device
> without the NDOs?
No. v3 will pick the netdev source only when ndo_hwtstamp_set is
available.
> [...]
> [Severity: Low]
>
> This check runs before dev->hwprov or the requested provider is looked
> at,
> and it only considers dev->phydev. Could it reject requests that an
> already
> installed PHYLIB provider can serve?
Right, it ignores an installed provider. v3 will also pass when
dev->hwprov is set.
> [...]
pw-bot: cr
prev parent reply other threads:[~2026-09-25 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260923121644.2194183-1-nb@tipi-net.de>
2026-09-23 12:16 ` [PATCH net v2 1/2] net: ethtool: don't match a hwtstamp provider on a device without a PHC Nicolai Buchwitz
2026-09-23 13:00 ` Nicolai Buchwitz
2026-09-24 12:20 ` netdev-bot+sashiko
2026-09-25 9:07 ` Nicolai Buchwitz
2026-09-23 12:16 ` [PATCH net v2 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider Nicolai Buchwitz
2026-09-24 12:20 ` netdev-bot+sashiko
2026-09-25 9:15 ` Nicolai Buchwitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=802cc23e2050dfbe56b7564b921e06ad@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.