* [U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator
@ 2013-06-05 21:17 Fabio Estevam
2013-06-05 21:24 ` Benoît Thébaudeau
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2013-06-05 21:17 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
No need to use the or operator, so just remove it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/vf610twr/vf610twr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/vf610twr/vf610twr.c b/board/freescale/vf610twr/vf610twr.c
index 04fa882..1156194 100644
--- a/board/freescale/vf610twr/vf610twr.c
+++ b/board/freescale/vf610twr/vf610twr.c
@@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
imx_iomux_v3_setup_multiple_pads(
esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
- status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
+ status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
return status;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator
2013-06-05 21:17 [U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator Fabio Estevam
@ 2013-06-05 21:24 ` Benoît Thébaudeau
2013-06-05 21:42 ` Otavio Salvador
0 siblings, 1 reply; 3+ messages in thread
From: Benoît Thébaudeau @ 2013-06-05 21:24 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On Wednesday, June 5, 2013 11:17:45 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> No need to use the or operator, so just remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/vf610twr/vf610twr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/vf610twr/vf610twr.c
> b/board/freescale/vf610twr/vf610twr.c
> index 04fa882..1156194 100644
> --- a/board/freescale/vf610twr/vf610twr.c
> +++ b/board/freescale/vf610twr/vf610twr.c
> @@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
> imx_iomux_v3_setup_multiple_pads(
> esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
>
> - status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> + status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
>
> return status;
> }
> --
> 1.8.1.2
Or even better, completely drop status and use
"return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);".
Best regards,
Beno?t
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator
2013-06-05 21:24 ` Benoît Thébaudeau
@ 2013-06-05 21:42 ` Otavio Salvador
0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2013-06-05 21:42 UTC (permalink / raw)
To: u-boot
On Wed, Jun 5, 2013 at 6:24 PM, Beno?t Th?baudeau <
benoit.thebaudeau@advansee.com> wrote:
> Hi Fabio,
>
> On Wednesday, June 5, 2013 11:17:45 PM, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > No need to use the or operator, so just remove it.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > board/freescale/vf610twr/vf610twr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/freescale/vf610twr/vf610twr.c
> > b/board/freescale/vf610twr/vf610twr.c
> > index 04fa882..1156194 100644
> > --- a/board/freescale/vf610twr/vf610twr.c
> > +++ b/board/freescale/vf610twr/vf610twr.c
> > @@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
> > imx_iomux_v3_setup_multiple_pads(
> > esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
> >
> > - status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> > + status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> >
> > return status;
> > }
> > --
> > 1.8.1.2
>
> Or even better, completely drop status and use
> "return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);".
>
+1 :)
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-05 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05 21:17 [U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator Fabio Estevam
2013-06-05 21:24 ` Benoît Thébaudeau
2013-06-05 21:42 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.