All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: magnus.damm@gmail.com, geert@glider.be, mchehab@kernel.org,
	hverkuil@xs4all.nl, festevam@gmail.com, sakari.ailus@iki.fi,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
	linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 9/9] arch: sh: migor: Use new renesas-ceu camera driver
Date: Thu, 04 Jan 2018 22:10:30 +0200	[thread overview]
Message-ID: <8062486.QngExgQv9j@avalon> (raw)
In-Reply-To: <1515081797-17174-10-git-send-email-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thank you for the patch.

On Thursday, 4 January 2018 18:03:17 EET Jacopo Mondi wrote:
> Migo-R platform uses sh_mobile_ceu camera driver, which is now being
> replaced by a proper V4L2 camera driver named 'renesas-ceu'.
> 
> Move Migo-R platform to use the v4l2 renesas-ceu camera driver
> interface and get rid of soc_camera defined components used to register
> sensor drivers and of platform specific enable/disable routines.
> 
> Register clock source and GPIOs for sensor drivers, so they can use
> clock and gpio APIs.
> 
> Also, memory for CEU video buffers is now reserved with membocks APIs,
> and need to be declared as dma_coherent during machine initialization to
> remove that architecture specific part from CEU driver.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/sh/boards/mach-migor/setup.c      | 225 ++++++++++++++----------------
>  arch/sh/kernel/cpu/sh4a/clock-sh7722.c |   2 +-
>  2 files changed, 101 insertions(+), 126 deletions(-)

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: magnus.damm@gmail.com, geert@glider.be, mchehab@kernel.org,
	hverkuil@xs4all.nl, festevam@gmail.com, sakari.ailus@iki.fi,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
	linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 9/9] arch: sh: migor: Use new renesas-ceu camera driver
Date: Thu, 04 Jan 2018 20:10:30 +0000	[thread overview]
Message-ID: <8062486.QngExgQv9j@avalon> (raw)
In-Reply-To: <1515081797-17174-10-git-send-email-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thank you for the patch.

On Thursday, 4 January 2018 18:03:17 EET Jacopo Mondi wrote:
> Migo-R platform uses sh_mobile_ceu camera driver, which is now being
> replaced by a proper V4L2 camera driver named 'renesas-ceu'.
> 
> Move Migo-R platform to use the v4l2 renesas-ceu camera driver
> interface and get rid of soc_camera defined components used to register
> sensor drivers and of platform specific enable/disable routines.
> 
> Register clock source and GPIOs for sensor drivers, so they can use
> clock and gpio APIs.
> 
> Also, memory for CEU video buffers is now reserved with membocks APIs,
> and need to be declared as dma_coherent during machine initialization to
> remove that architecture specific part from CEU driver.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/sh/boards/mach-migor/setup.c      | 225 ++++++++++++++----------------
>  arch/sh/kernel/cpu/sh4a/clock-sh7722.c |   2 +-
>  2 files changed, 101 insertions(+), 126 deletions(-)

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2018-01-04 20:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 16:03 [PATCH v3 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Jacopo Mondi
2018-01-04 16:03 ` Jacopo Mondi
2018-01-04 16:03 ` [PATCH v3 1/9] dt-bindings: media: Add Renesas CEU bindings Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 22:28   ` Laurent Pinchart
2018-01-04 22:28     ` Laurent Pinchart
2018-01-04 22:28     ` Laurent Pinchart
2018-01-05  8:56     ` Geert Uytterhoeven
2018-01-05  8:56       ` Geert Uytterhoeven
2018-01-05  8:56       ` Geert Uytterhoeven
2018-01-05 17:55     ` jacopo mondi
2018-01-05 17:55       ` jacopo mondi
2018-01-04 16:03 ` [PATCH v3 2/9] include: media: Add Renesas CEU driver interface Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:03 ` [PATCH v3 3/9] v4l: platform: Add Renesas CEU driver Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 20:41   ` Laurent Pinchart
2018-01-04 20:41     ` Laurent Pinchart
2018-01-04 16:03 ` [PATCH v3 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:43   ` Simon Horman
2018-01-04 16:43     ` Simon Horman
2018-01-04 16:43     ` Simon Horman
2018-01-04 16:03 ` [PATCH v3 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:03 ` [PATCH v3 6/9] media: i2c: ov772x: Remove soc_camera dependencies Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 22:20   ` Laurent Pinchart
2018-01-04 22:20     ` Laurent Pinchart
2018-01-04 16:03 ` [PATCH v3 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:03 ` [PATCH v3 8/9] media: i2c: tw9910: Remove soc_camera dependencies Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 16:03 ` [PATCH v3 9/9] arch: sh: migor: Use new renesas-ceu camera driver Jacopo Mondi
2018-01-04 16:03   ` Jacopo Mondi
2018-01-04 20:10   ` Laurent Pinchart [this message]
2018-01-04 20:10     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8062486.QngExgQv9j@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=geert@glider.be \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.