From: Paul Parsons <lost.distance@yahoo.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com
Subject: Re: [PATCH 1/2] mfd: Add ASIC3 LED support
Date: Tue, 3 May 2011 20:46:12 +0100 (BST) [thread overview]
Message-ID: <812143.47267.qm@web29018.mail.ird.yahoo.com> (raw)
In-Reply-To: <1304419293.13769.13.camel@flow>
Hi Philipp,
--- On Tue, 3/5/11, Philipp Zabel <philipp.zabel@gmail.com> wrote:
> I'd like to avoid this export. Could you inform the cell
> driver of
> mapping and bus shift via io resources as it is done in
> ds1wm?
> Same for this one.
The LED registers are already mapped by the mfd driver, and the functions to access them are already provided. My feeling is that replicating all of that seems a high price to pay to avoid exporting a couple of functions.
> Ok for now, I guess. But it's unrelated to led support. And
> once we have
> a common struct clk and can use clk_enable in the led
> driver, there's
> going to be error checking anyway...
Yes, that's a separate patch if at all.
> As Samuel pointed out, better use .platform_data and
> .platform_size here
> right away.
Will do.
> Separate patch?
Separate patch.
> As I said, not convinced about that one. I'll follow up
> with a patch to
> test on top of yours.
OK.
Regards,
Paul
prev parent reply other threads:[~2011-05-03 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 17:59 [PATCH 1/2] mfd: Add ASIC3 LED support Paul Parsons
2011-05-02 15:39 ` Samuel Ortiz
2011-05-02 22:16 ` Paul Parsons
2011-05-03 8:33 ` Samuel Ortiz
2011-05-03 10:41 ` Philipp Zabel
2011-05-03 10:46 ` Philipp Zabel
2011-05-03 15:38 ` Paul Parsons
2011-05-03 19:46 ` Paul Parsons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812143.47267.qm@web29018.mail.ird.yahoo.com \
--to=lost.distance@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.