All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Csókás Bence" <csokas.bence@prolan.hu>
Cc: "Michael Walle" <mwalle@kernel.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Tamás Szentendrei" <szentendrei.tamas@prolan.hu>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	pratyush <pratyush@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [PATCH] spi-nor: Verify written data in paranoid mode
Date: Wed, 16 Apr 2025 20:41:18 +0200 (CEST)	[thread overview]
Message-ID: <81225127.297167214.1744828878236.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <c56c52c0-a824-4ad7-9847-e0e973f811ed@prolan.hu>

----- Ursprüngliche Mail -----
> Von: "Csókás Bence" <csokas.bence@prolan.hu>
>> I'm not so sure whether it makes sense at all.
>> In it's current form, there is no recovery. So anything non-trivial
>> on top of the MTD will just see an -EIO and has to give up.
>> E.g. a filesystem will remount read-only.
> 
> In our case, we use UBIFS on top of UBI, which in this case chooses
> another eraseblock to hold the data instead, then re-tests (erase+write
> cycles) the one which gave -EIO. Since the bus error is only transient,
> it goes away by this time, and thus UBIFS will recover from this cleanly.

Are you sure about that?

I'd expect UBI to go into RO mode via a call path like:
ubi_eba_write_leb() -> ubi_io_write() -> mtd_write()
If mtd_write() returns an EIO, UBI will go into RO mode immediately.

(I'm assuming, your SPI-NOR has no bad block support, so ubi->bad_allowed
is false).

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: "Csókás Bence" <csokas.bence@prolan.hu>
Cc: "Michael Walle" <mwalle@kernel.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Tamás Szentendrei" <szentendrei.tamas@prolan.hu>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	pratyush <pratyush@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [PATCH] spi-nor: Verify written data in paranoid mode
Date: Wed, 16 Apr 2025 20:41:18 +0200 (CEST)	[thread overview]
Message-ID: <81225127.297167214.1744828878236.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <c56c52c0-a824-4ad7-9847-e0e973f811ed@prolan.hu>

----- Ursprüngliche Mail -----
> Von: "Csókás Bence" <csokas.bence@prolan.hu>
>> I'm not so sure whether it makes sense at all.
>> In it's current form, there is no recovery. So anything non-trivial
>> on top of the MTD will just see an -EIO and has to give up.
>> E.g. a filesystem will remount read-only.
> 
> In our case, we use UBIFS on top of UBI, which in this case chooses
> another eraseblock to hold the data instead, then re-tests (erase+write
> cycles) the one which gave -EIO. Since the bus error is only transient,
> it goes away by this time, and thus UBIFS will recover from this cleanly.

Are you sure about that?

I'd expect UBI to go into RO mode via a call path like:
ubi_eba_write_leb() -> ubi_io_write() -> mtd_write()
If mtd_write() returns an EIO, UBI will go into RO mode immediately.

(I'm assuming, your SPI-NOR has no bad block support, so ubi->bad_allowed
is false).

Thanks,
//richard

  reply	other threads:[~2025-04-16 18:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 18:04 [PATCH] spi-nor: Verify written data in paranoid mode Bence Csókás
2025-04-15 18:04 ` Bence Csókás
2025-04-16 11:59 ` Michael Walle
2025-04-16 11:59   ` Michael Walle
2025-04-16 12:38   ` Csókás Bence
2025-04-16 12:38     ` Csókás Bence
2025-04-16 13:09     ` Richard Weinberger
2025-04-16 13:09       ` Richard Weinberger
2025-04-16 14:44       ` Csókás Bence
2025-04-16 14:44         ` Csókás Bence
2025-04-16 18:41         ` Richard Weinberger [this message]
2025-04-16 18:41           ` Richard Weinberger
2025-05-08  9:42           ` Csókás Bence
2025-05-08  9:42             ` Csókás Bence

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81225127.297167214.1744828878236.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=csokas.bence@prolan.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=szentendrei.tamas@prolan.hu \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.