* [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency
@ 2022-10-19 14:27 ` Quentin Schulz
0 siblings, 0 replies; 18+ messages in thread
From: Quentin Schulz @ 2022-10-19 14:27 UTC (permalink / raw)
To: foss+kernel, Krzysztof Kozlowski, Heiko Stuebner, Rob Herring
Cc: Quentin Schulz, devicetree, linux-arm-kernel, linux-rockchip,
Jakob Unterwurzacher, linux-kernel, stable
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
CRC errors (code -84 EILSEQ) have been observed for some SanDisk
Ultra A1 cards when running at 50MHz.
Waveform analysis suggest that the level shifters that are used on the
RK3399-Q7 module for voltage translation between 3.0 and 3.3V don't
handle clock rates at or above 48MHz properly. Back off to 40MHz for
some safety margin.
Cc: stable@vger.kernel.org
Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM")
Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
We've been carrying this patch downstream for years and completely forgot to
upstream it. This is now done.
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
---
arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
index 04c752f49be9..115c14c0a3c6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
@@ -207,7 +207,7 @@ &sdmmc {
cap-sd-highspeed;
cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
disable-wp;
- max-frequency = <150000000>;
+ max-frequency = <40000000>;
pinctrl-names = "default";
pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
vmmc-supply = <&vcc3v3_baseboard>;
---
base-commit: aae703b02f92bde9264366c545e87cec451de471
change-id: 20221019-upstream-puma-sd-40mhz-b5aef1c351e6
Best regards,
--
Quentin Schulz <quentin.schulz@theobroma-systems.com>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 14:27 ` Quentin Schulz 0 siblings, 0 replies; 18+ messages in thread From: Quentin Schulz @ 2022-10-19 14:27 UTC (permalink / raw) To: foss+kernel, Krzysztof Kozlowski, Heiko Stuebner, Rob Herring Cc: Quentin Schulz, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable From: Quentin Schulz <quentin.schulz@theobroma-systems.com> From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> CRC errors (code -84 EILSEQ) have been observed for some SanDisk Ultra A1 cards when running at 50MHz. Waveform analysis suggest that the level shifters that are used on the RK3399-Q7 module for voltage translation between 3.0 and 3.3V don't handle clock rates at or above 48MHz properly. Back off to 40MHz for some safety margin. Cc: stable@vger.kernel.org Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM") Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> --- We've been carrying this patch downstream for years and completely forgot to upstream it. This is now done. To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Heiko Stuebner <heiko@sntech.de> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> --- arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts index 04c752f49be9..115c14c0a3c6 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts @@ -207,7 +207,7 @@ &sdmmc { cap-sd-highspeed; cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>; disable-wp; - max-frequency = <150000000>; + max-frequency = <40000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; vmmc-supply = <&vcc3v3_baseboard>; --- base-commit: aae703b02f92bde9264366c545e87cec451de471 change-id: 20221019-upstream-puma-sd-40mhz-b5aef1c351e6 Best regards, -- Quentin Schulz <quentin.schulz@theobroma-systems.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 14:27 ` Quentin Schulz 0 siblings, 0 replies; 18+ messages in thread From: Quentin Schulz @ 2022-10-19 14:27 UTC (permalink / raw) To: foss+kernel, Krzysztof Kozlowski, Heiko Stuebner, Rob Herring Cc: Quentin Schulz, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable From: Quentin Schulz <quentin.schulz@theobroma-systems.com> From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> CRC errors (code -84 EILSEQ) have been observed for some SanDisk Ultra A1 cards when running at 50MHz. Waveform analysis suggest that the level shifters that are used on the RK3399-Q7 module for voltage translation between 3.0 and 3.3V don't handle clock rates at or above 48MHz properly. Back off to 40MHz for some safety margin. Cc: stable@vger.kernel.org Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM") Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> --- We've been carrying this patch downstream for years and completely forgot to upstream it. This is now done. To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Heiko Stuebner <heiko@sntech.de> Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> --- arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts index 04c752f49be9..115c14c0a3c6 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts @@ -207,7 +207,7 @@ &sdmmc { cap-sd-highspeed; cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>; disable-wp; - max-frequency = <150000000>; + max-frequency = <40000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; vmmc-supply = <&vcc3v3_baseboard>; --- base-commit: aae703b02f92bde9264366c545e87cec451de471 change-id: 20221019-upstream-puma-sd-40mhz-b5aef1c351e6 Best regards, -- Quentin Schulz <quentin.schulz@theobroma-systems.com> ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency 2022-10-19 14:27 ` Quentin Schulz (?) @ 2022-10-19 14:56 ` Greg KH -1 siblings, 0 replies; 18+ messages in thread From: Greg KH @ 2022-10-19 14:56 UTC (permalink / raw) To: Quentin Schulz Cc: Krzysztof Kozlowski, Heiko Stuebner, Rob Herring, Quentin Schulz, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> You can not have 2 authors :( > > CRC errors (code -84 EILSEQ) have been observed for some SanDisk > Ultra A1 cards when running at 50MHz. > > Waveform analysis suggest that the level shifters that are used on the > RK3399-Q7 module for voltage translation between 3.0 and 3.3V don't > handle clock rates at or above 48MHz properly. Back off to 40MHz for > some safety margin. > > Cc: stable@vger.kernel.org > Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM") > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- > We've been carrying this patch downstream for years and completely forgot to > upstream it. This is now done. It has to be accepted before you are done :) thanks, greg k-h _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 14:56 ` Greg KH 0 siblings, 0 replies; 18+ messages in thread From: Greg KH @ 2022-10-19 14:56 UTC (permalink / raw) To: Quentin Schulz Cc: Krzysztof Kozlowski, Heiko Stuebner, Rob Herring, Quentin Schulz, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> You can not have 2 authors :( > > CRC errors (code -84 EILSEQ) have been observed for some SanDisk > Ultra A1 cards when running at 50MHz. > > Waveform analysis suggest that the level shifters that are used on the > RK3399-Q7 module for voltage translation between 3.0 and 3.3V don't > handle clock rates at or above 48MHz properly. Back off to 40MHz for > some safety margin. > > Cc: stable@vger.kernel.org > Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM") > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- > We've been carrying this patch downstream for years and completely forgot to > upstream it. This is now done. It has to be accepted before you are done :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 14:56 ` Greg KH 0 siblings, 0 replies; 18+ messages in thread From: Greg KH @ 2022-10-19 14:56 UTC (permalink / raw) To: Quentin Schulz Cc: Krzysztof Kozlowski, Heiko Stuebner, Rob Herring, Quentin Schulz, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> You can not have 2 authors :( > > CRC errors (code -84 EILSEQ) have been observed for some SanDisk > Ultra A1 cards when running at 50MHz. > > Waveform analysis suggest that the level shifters that are used on the > RK3399-Q7 module for voltage translation between 3.0 and 3.3V don't > handle clock rates at or above 48MHz properly. Back off to 40MHz for > some safety margin. > > Cc: stable@vger.kernel.org > Fixes: 60fd9f72ce8a ("arm64: dts: rockchip: add Haikou baseboard with RK3399-Q7 SoM") > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > --- > We've been carrying this patch downstream for years and completely forgot to > upstream it. This is now done. It has to be accepted before you are done :) thanks, greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency 2022-10-19 14:56 ` Greg KH (?) @ 2022-10-19 15:59 ` quentin.schulz -1 siblings, 0 replies; 18+ messages in thread From: quentin.schulz @ 2022-10-19 15:59 UTC (permalink / raw) To: Greg KH, Quentin Schulz, Krzysztof Kozlowski, Heiko Stuebner, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable Hi Greg, On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > You can not have 2 authors :( > That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! [...] > It has to be accepted before you are done :) > A "small" detail :) Cheers, Quentin _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 15:59 ` quentin.schulz 0 siblings, 0 replies; 18+ messages in thread From: quentin.schulz @ 2022-10-19 15:59 UTC (permalink / raw) To: Greg KH, Quentin Schulz, Krzysztof Kozlowski, Heiko Stuebner, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable Hi Greg, On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > You can not have 2 authors :( > That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! [...] > It has to be accepted before you are done :) > A "small" detail :) Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 15:59 ` quentin.schulz 0 siblings, 0 replies; 18+ messages in thread From: quentin.schulz @ 2022-10-19 15:59 UTC (permalink / raw) To: Greg KH, Quentin Schulz, Krzysztof Kozlowski, Heiko Stuebner, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable Hi Greg, On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > You can not have 2 authors :( > That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! [...] > It has to be accepted before you are done :) > A "small" detail :) Cheers, Quentin ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency 2022-10-19 15:59 ` quentin.schulz (?) @ 2022-10-19 17:15 ` Heiko Stuebner -1 siblings, 0 replies; 18+ messages in thread From: Heiko Stuebner @ 2022-10-19 17:15 UTC (permalink / raw) To: Greg KH, Quentin Schulz, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable, quentin.schulz Hi Quentin, Am Mittwoch, 19. Oktober 2022, 17:59:54 CEST schrieb quentin.schulz@theobroma-systems.com: > Hi Greg, > > On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > > > > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > > > You can not have 2 authors :( > > > > That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! I guess, Jakob is the original author? If so, I can simply drop your authorship. Heiko > > [...] > > > It has to be accepted before you are done :) > > > > A "small" detail :) > > Cheers, > Quentin > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 17:15 ` Heiko Stuebner 0 siblings, 0 replies; 18+ messages in thread From: Heiko Stuebner @ 2022-10-19 17:15 UTC (permalink / raw) To: Greg KH, Quentin Schulz, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable, quentin.schulz Hi Quentin, Am Mittwoch, 19. Oktober 2022, 17:59:54 CEST schrieb quentin.schulz@theobroma-systems.com: > Hi Greg, > > On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > > > > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > > > You can not have 2 authors :( > > > > That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! I guess, Jakob is the original author? If so, I can simply drop your authorship. Heiko > > [...] > > > It has to be accepted before you are done :) > > > > A "small" detail :) > > Cheers, > Quentin > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-19 17:15 ` Heiko Stuebner 0 siblings, 0 replies; 18+ messages in thread From: Heiko Stuebner @ 2022-10-19 17:15 UTC (permalink / raw) To: Greg KH, Quentin Schulz, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable, quentin.schulz Hi Quentin, Am Mittwoch, 19. Oktober 2022, 17:59:54 CEST schrieb quentin.schulz@theobroma-systems.com: > Hi Greg, > > On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: > > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > > > > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > > > You can not have 2 authors :( > > > > That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! I guess, Jakob is the original author? If so, I can simply drop your authorship. Heiko > > [...] > > > It has to be accepted before you are done :) > > > > A "small" detail :) > > Cheers, > Quentin > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency 2022-10-19 17:15 ` Heiko Stuebner (?) @ 2022-10-20 8:32 ` Quentin Schulz -1 siblings, 0 replies; 18+ messages in thread From: Quentin Schulz @ 2022-10-20 8:32 UTC (permalink / raw) To: Heiko Stuebner, Greg KH, Quentin Schulz, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable Hi Heiko, On 10/19/22 19:15, Heiko Stuebner wrote: > Hi Quentin, > > Am Mittwoch, 19. Oktober 2022, 17:59:54 CEST schrieb quentin.schulz@theobroma-systems.com: >> Hi Greg, >> >> On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >>> On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: >>>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com> >>>> >>>> From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> >>> >>> You can not have 2 authors :( >>> >> >> That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! > > I guess, Jakob is the original author? Correct. > If so, I can simply drop your authorship. > Up to you, don't want to increase maintainer's burden. I'll send a v2 Monday if you haven't sent the usual "Applied thanks" mail by then :) (or if there's feedback of course). Will work on fixing my workflow/tools til then. Cheers, Quentin > > Heiko > >> >> [...] >> >>> It has to be accepted before you are done :) >>> >> >> A "small" detail :) >> >> Cheers, >> Quentin >> > > > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-20 8:32 ` Quentin Schulz 0 siblings, 0 replies; 18+ messages in thread From: Quentin Schulz @ 2022-10-20 8:32 UTC (permalink / raw) To: Heiko Stuebner, Greg KH, Quentin Schulz, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable Hi Heiko, On 10/19/22 19:15, Heiko Stuebner wrote: > Hi Quentin, > > Am Mittwoch, 19. Oktober 2022, 17:59:54 CEST schrieb quentin.schulz@theobroma-systems.com: >> Hi Greg, >> >> On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >>> On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: >>>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com> >>>> >>>> From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> >>> >>> You can not have 2 authors :( >>> >> >> That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! > > I guess, Jakob is the original author? Correct. > If so, I can simply drop your authorship. > Up to you, don't want to increase maintainer's burden. I'll send a v2 Monday if you haven't sent the usual "Applied thanks" mail by then :) (or if there's feedback of course). Will work on fixing my workflow/tools til then. Cheers, Quentin > > Heiko > >> >> [...] >> >>> It has to be accepted before you are done :) >>> >> >> A "small" detail :) >> >> Cheers, >> Quentin >> > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-20 8:32 ` Quentin Schulz 0 siblings, 0 replies; 18+ messages in thread From: Quentin Schulz @ 2022-10-20 8:32 UTC (permalink / raw) To: Heiko Stuebner, Greg KH, Quentin Schulz, Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel, linux-rockchip, Jakob Unterwurzacher, linux-kernel, stable Hi Heiko, On 10/19/22 19:15, Heiko Stuebner wrote: > Hi Quentin, > > Am Mittwoch, 19. Oktober 2022, 17:59:54 CEST schrieb quentin.schulz@theobroma-systems.com: >> Hi Greg, >> >> On 10/19/22 4:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >>> On Wed, Oct 19, 2022 at 04:27:27PM +0200, Quentin Schulz wrote: >>>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com> >>>> >>>> From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> >>> >>> You can not have 2 authors :( >>> >> >> That's a bug in b4 and my patch submission/mail sending workflow, I'll sort something out with the b4 community and send a new version of the patch soon. Thanks for the heads up! > > I guess, Jakob is the original author? Correct. > If so, I can simply drop your authorship. > Up to you, don't want to increase maintainer's burden. I'll send a v2 Monday if you haven't sent the usual "Applied thanks" mail by then :) (or if there's feedback of course). Will work on fixing my workflow/tools til then. Cheers, Quentin > > Heiko > >> >> [...] >> >>> It has to be accepted before you are done :) >>> >> >> A "small" detail :) >> >> Cheers, >> Quentin >> > > > > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency 2022-10-19 14:27 ` Quentin Schulz (?) @ 2022-10-20 9:49 ` Heiko Stuebner -1 siblings, 0 replies; 18+ messages in thread From: Heiko Stuebner @ 2022-10-20 9:49 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Quentin Schulz Cc: Heiko Stuebner, linux-rockchip, linux-arm-kernel, Jakob Unterwurzacher, devicetree, Quentin Schulz, stable, linux-kernel On Wed, 19 Oct 2022 16:27:27 +0200, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > CRC errors (code -84 EILSEQ) have been observed for some SanDisk > Ultra A1 cards when running at 50MHz. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency commit: 91e8b74fe6381e083f8aa55217bb0562785ab398 Best regards, -- Heiko Stuebner <heiko@sntech.de> _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-20 9:49 ` Heiko Stuebner 0 siblings, 0 replies; 18+ messages in thread From: Heiko Stuebner @ 2022-10-20 9:49 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Quentin Schulz Cc: Heiko Stuebner, linux-rockchip, linux-arm-kernel, Jakob Unterwurzacher, devicetree, Quentin Schulz, stable, linux-kernel On Wed, 19 Oct 2022 16:27:27 +0200, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > CRC errors (code -84 EILSEQ) have been observed for some SanDisk > Ultra A1 cards when running at 50MHz. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency commit: 91e8b74fe6381e083f8aa55217bb0562785ab398 Best regards, -- Heiko Stuebner <heiko@sntech.de> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency @ 2022-10-20 9:49 ` Heiko Stuebner 0 siblings, 0 replies; 18+ messages in thread From: Heiko Stuebner @ 2022-10-20 9:49 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Quentin Schulz Cc: Heiko Stuebner, linux-rockchip, linux-arm-kernel, Jakob Unterwurzacher, devicetree, Quentin Schulz, stable, linux-kernel On Wed, 19 Oct 2022 16:27:27 +0200, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > > CRC errors (code -84 EILSEQ) have been observed for some SanDisk > Ultra A1 cards when running at 50MHz. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency commit: 91e8b74fe6381e083f8aa55217bb0562785ab398 Best regards, -- Heiko Stuebner <heiko@sntech.de> ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2022-10-20 9:51 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-19 14:27 [PATCH] arm64: dts: rockchip: lower rk3399-puma-haikou SD controller clock frequency Quentin Schulz 2022-10-19 14:27 ` Quentin Schulz 2022-10-19 14:27 ` Quentin Schulz 2022-10-19 14:56 ` Greg KH 2022-10-19 14:56 ` Greg KH 2022-10-19 14:56 ` Greg KH 2022-10-19 15:59 ` quentin.schulz 2022-10-19 15:59 ` quentin.schulz 2022-10-19 15:59 ` quentin.schulz 2022-10-19 17:15 ` Heiko Stuebner 2022-10-19 17:15 ` Heiko Stuebner 2022-10-19 17:15 ` Heiko Stuebner 2022-10-20 8:32 ` Quentin Schulz 2022-10-20 8:32 ` Quentin Schulz 2022-10-20 8:32 ` Quentin Schulz 2022-10-20 9:49 ` Heiko Stuebner 2022-10-20 9:49 ` Heiko Stuebner 2022-10-20 9:49 ` Heiko Stuebner
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.