* [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM
@ 2025-12-09 15:09 Melissa Wen
2026-02-03 2:03 ` Melissa Wen
2026-02-04 19:44 ` Alex Hung
0 siblings, 2 replies; 4+ messages in thread
From: Melissa Wen @ 2025-12-09 15:09 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, siqueira, alexander.deucher,
christian.koenig, airlied, simona
Cc: Matthew Schwartz, amd-gfx, dri-devel, kernel-dev
Since commit 39923050615cd ("drm/amd/display: Clear DPP 3DLUT Cap")
there is a flag in the mpc_color_caps that indicates the pre-blend usage
of MPC color caps. Do the same as commit a0c3e8bfbab6 ("drm/amd/display:
Use mpc.preblend flag to indicate preblend") and use the mpc.preblend
flag to expose plane blend LUT/TF properties on AMD display driver.
CC: Matthew Schwartz <matthew.schwartz@linux.dev>
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index 56cb866ac6f8..b15f0cf86008 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
@@ -1649,7 +1649,7 @@ dm_atomic_plane_attach_color_mgmt_properties(struct amdgpu_display_manager *dm,
MAX_COLOR_3DLUT_SIZE);
}
- if (dpp_color_caps.ogam_ram) {
+ if (dpp_color_caps.ogam_ram || dm->dc->caps.color.mpc.preblend) {
drm_object_attach_property(&plane->base,
mode_info.plane_blend_lut_property, 0);
drm_object_attach_property(&plane->base,
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM
2025-12-09 15:09 [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM Melissa Wen
@ 2026-02-03 2:03 ` Melissa Wen
2026-02-03 2:05 ` Matthew Schwartz
2026-02-04 19:44 ` Alex Hung
1 sibling, 1 reply; 4+ messages in thread
From: Melissa Wen @ 2026-02-03 2:03 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, siqueira, alexander.deucher,
christian.koenig, airlied, simona
Cc: Matthew Schwartz, amd-gfx, dri-devel, kernel-dev, Alex Hung
On 09/12/2025 12:09, Melissa Wen wrote:
> Since commit 39923050615cd ("drm/amd/display: Clear DPP 3DLUT Cap")
> there is a flag in the mpc_color_caps that indicates the pre-blend usage
> of MPC color caps. Do the same as commit a0c3e8bfbab6 ("drm/amd/display:
> Use mpc.preblend flag to indicate preblend") and use the mpc.preblend
> flag to expose plane blend LUT/TF properties on AMD display driver.
A gentle ping here.
Melissa
>
> CC: Matthew Schwartz <matthew.schwartz@linux.dev>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> index 56cb866ac6f8..b15f0cf86008 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> @@ -1649,7 +1649,7 @@ dm_atomic_plane_attach_color_mgmt_properties(struct amdgpu_display_manager *dm,
> MAX_COLOR_3DLUT_SIZE);
> }
>
> - if (dpp_color_caps.ogam_ram) {
> + if (dpp_color_caps.ogam_ram || dm->dc->caps.color.mpc.preblend) {
> drm_object_attach_property(&plane->base,
> mode_info.plane_blend_lut_property, 0);
> drm_object_attach_property(&plane->base,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM
2026-02-03 2:03 ` Melissa Wen
@ 2026-02-03 2:05 ` Matthew Schwartz
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Schwartz @ 2026-02-03 2:05 UTC (permalink / raw)
To: Melissa Wen, harry.wentland, sunpeng.li, siqueira,
alexander.deucher, christian.koenig, airlied, simona
Cc: amd-gfx, dri-devel, kernel-dev, Alex Hung
On 2/2/26 6:03 PM, Melissa Wen wrote:
>
> On 09/12/2025 12:09, Melissa Wen wrote:
>> Since commit 39923050615cd ("drm/amd/display: Clear DPP 3DLUT Cap")
>> there is a flag in the mpc_color_caps that indicates the pre-blend usage
>> of MPC color caps. Do the same as commit a0c3e8bfbab6 ("drm/amd/display:
>> Use mpc.preblend flag to indicate preblend") and use the mpc.preblend
>> flag to expose plane blend LUT/TF properties on AMD display driver.
>
> A gentle ping here.
>
> Melissa
>
>>
>> CC: Matthew Schwartz <matthew.schwartz@linux.dev>
I can confirm this adds back color management capabilities in gamescope on DCN35 and DCN351.
Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
>> Signed-off-by: Melissa Wen <mwen@igalia.com>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> index 56cb866ac6f8..b15f0cf86008 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
>> @@ -1649,7 +1649,7 @@ dm_atomic_plane_attach_color_mgmt_properties(struct amdgpu_display_manager *dm,
>> MAX_COLOR_3DLUT_SIZE);
>> }
>> - if (dpp_color_caps.ogam_ram) {
>> + if (dpp_color_caps.ogam_ram || dm->dc->caps.color.mpc.preblend) {
>> drm_object_attach_property(&plane->base,
>> mode_info.plane_blend_lut_property, 0);
>> drm_object_attach_property(&plane->base,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM
2025-12-09 15:09 [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM Melissa Wen
2026-02-03 2:03 ` Melissa Wen
@ 2026-02-04 19:44 ` Alex Hung
1 sibling, 0 replies; 4+ messages in thread
From: Alex Hung @ 2026-02-04 19:44 UTC (permalink / raw)
To: Melissa Wen, harry.wentland, sunpeng.li, siqueira,
alexander.deucher, christian.koenig, airlied, simona
Cc: Matthew Schwartz, amd-gfx, dri-devel, kernel-dev
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 12/9/25 08:09, Melissa Wen wrote:
> Since commit 39923050615cd ("drm/amd/display: Clear DPP 3DLUT Cap")
> there is a flag in the mpc_color_caps that indicates the pre-blend usage
> of MPC color caps. Do the same as commit a0c3e8bfbab6 ("drm/amd/display:
> Use mpc.preblend flag to indicate preblend") and use the mpc.preblend
> flag to expose plane blend LUT/TF properties on AMD display driver.
>
> CC: Matthew Schwartz <matthew.schwartz@linux.dev>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> index 56cb866ac6f8..b15f0cf86008 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> @@ -1649,7 +1649,7 @@ dm_atomic_plane_attach_color_mgmt_properties(struct amdgpu_display_manager *dm,
> MAX_COLOR_3DLUT_SIZE);
> }
>
> - if (dpp_color_caps.ogam_ram) {
> + if (dpp_color_caps.ogam_ram || dm->dc->caps.color.mpc.preblend) {
> drm_object_attach_property(&plane->base,
> mode_info.plane_blend_lut_property, 0);
> drm_object_attach_property(&plane->base,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-04 19:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-09 15:09 [PATCH] drm/amd/display: expose plane blend LUT in HW with MCM Melissa Wen
2026-02-03 2:03 ` Melissa Wen
2026-02-03 2:05 ` Matthew Schwartz
2026-02-04 19:44 ` Alex Hung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.