From: "Heiko Stübner" <heiko@sntech.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org, Jarrah <kernel@undef.tools>
Cc: "Robert Mader" <robert.mader@collabora.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Ondrej Jirman" <megi@xff.cz>,
"Martijn Braam" <martijn@brixit.nl>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Caleb Connolly" <kc@postmarketos.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support
Date: Mon, 27 Mar 2023 11:11:19 +0200 [thread overview]
Message-ID: <8197476.T7Z3S40VBb@diego> (raw)
In-Reply-To: <e4f82c1e-621e-7e94-497d-8c579264f996@undef.tools>
Am Montag, 27. März 2023, 09:55:15 CEST schrieb Jarrah:
> Hi Javier,
>
> On 3/27/23 18:41, Javier Martinez Canillas wrote:
> > From: Ondrej Jirman <megi@xff.cz>
> >
> > The phone's display is using a Hannstar LCD panel. Support it by adding a
> > panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
> >
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > Co-developed-by: Martijn Braam <martijn@brixit.nl>
> > Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > ---
> >
> > Changes in v2:
> > - Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
>
>
> Any reason not to include this with the correct compatible string? It's
> been available since
> https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/.
> Swapping out gt917s for gt1158 in the node from your previous patch
> should be enough.
Just wondering if I'm blind, Javier's patch doesn't contain any touchscreen
controller (haven't found neither gt9* or gt11* mentioned there), so
I'm inclined to go with the "touchscreen can be added later" thing.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org, Jarrah <kernel@undef.tools>
Cc: "Robert Mader" <robert.mader@collabora.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Ondrej Jirman" <megi@xff.cz>,
"Martijn Braam" <martijn@brixit.nl>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Caleb Connolly" <kc@postmarketos.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support
Date: Mon, 27 Mar 2023 11:11:19 +0200 [thread overview]
Message-ID: <8197476.T7Z3S40VBb@diego> (raw)
In-Reply-To: <e4f82c1e-621e-7e94-497d-8c579264f996@undef.tools>
Am Montag, 27. März 2023, 09:55:15 CEST schrieb Jarrah:
> Hi Javier,
>
> On 3/27/23 18:41, Javier Martinez Canillas wrote:
> > From: Ondrej Jirman <megi@xff.cz>
> >
> > The phone's display is using a Hannstar LCD panel. Support it by adding a
> > panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
> >
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > Co-developed-by: Martijn Braam <martijn@brixit.nl>
> > Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > ---
> >
> > Changes in v2:
> > - Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
>
>
> Any reason not to include this with the correct compatible string? It's
> been available since
> https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/.
> Swapping out gt917s for gt1158 in the node from your previous patch
> should be enough.
Just wondering if I'm blind, Javier's patch doesn't contain any touchscreen
controller (haven't found neither gt9* or gt11* mentioned there), so
I'm inclined to go with the "touchscreen can be added later" thing.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org, Jarrah <kernel@undef.tools>
Cc: "Robert Mader" <robert.mader@collabora.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Ondrej Jirman" <megi@xff.cz>,
"Martijn Braam" <martijn@brixit.nl>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Caleb Connolly" <kc@postmarketos.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support
Date: Mon, 27 Mar 2023 11:11:19 +0200 [thread overview]
Message-ID: <8197476.T7Z3S40VBb@diego> (raw)
In-Reply-To: <e4f82c1e-621e-7e94-497d-8c579264f996@undef.tools>
Am Montag, 27. März 2023, 09:55:15 CEST schrieb Jarrah:
> Hi Javier,
>
> On 3/27/23 18:41, Javier Martinez Canillas wrote:
> > From: Ondrej Jirman <megi@xff.cz>
> >
> > The phone's display is using a Hannstar LCD panel. Support it by adding a
> > panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
> >
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > Co-developed-by: Martijn Braam <martijn@brixit.nl>
> > Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > ---
> >
> > Changes in v2:
> > - Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
>
>
> Any reason not to include this with the correct compatible string? It's
> been available since
> https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/.
> Swapping out gt917s for gt1158 in the node from your previous patch
> should be enough.
Just wondering if I'm blind, Javier's patch doesn't contain any touchscreen
controller (haven't found neither gt9* or gt11* mentioned there), so
I'm inclined to go with the "touchscreen can be added later" thing.
Heiko
next prev parent reply other threads:[~2023-03-27 9:11 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 7:41 [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
2023-03-27 7:41 ` Javier Martinez Canillas
2023-03-27 7:41 ` Javier Martinez Canillas
2023-03-27 7:55 ` Jarrah
2023-03-27 7:55 ` Jarrah
2023-03-27 7:55 ` Jarrah
2023-03-27 8:16 ` Javier Martinez Canillas
2023-03-27 8:16 ` Javier Martinez Canillas
2023-03-27 8:16 ` Javier Martinez Canillas
2023-03-27 9:11 ` Heiko Stübner [this message]
2023-03-27 9:11 ` Heiko Stübner
2023-03-27 9:11 ` Heiko Stübner
2023-03-27 9:15 ` Jarrah
2023-03-27 9:15 ` Jarrah
2023-03-27 9:15 ` Jarrah
2023-03-27 9:47 ` Javier Martinez Canillas
2023-03-27 9:47 ` Javier Martinez Canillas
2023-03-27 9:47 ` Javier Martinez Canillas
2023-03-27 13:01 ` Ondřej Jirman
2023-03-27 13:01 ` Ondřej Jirman
2023-03-27 13:01 ` Ondřej Jirman
2023-03-27 15:39 ` Javier Martinez Canillas
2023-03-27 15:39 ` Javier Martinez Canillas
2023-03-27 15:39 ` Javier Martinez Canillas
2023-03-27 15:57 ` Heiko Stübner
2023-03-27 15:57 ` Heiko Stübner
2023-03-27 15:57 ` Heiko Stübner
2023-03-27 16:05 ` Javier Martinez Canillas
2023-03-27 16:05 ` Javier Martinez Canillas
2023-03-27 16:05 ` Javier Martinez Canillas
2023-03-27 16:06 ` Javier Martinez Canillas
2023-03-27 16:06 ` Javier Martinez Canillas
2023-03-27 16:06 ` Javier Martinez Canillas
2023-03-27 16:15 ` Javier Martinez Canillas
2023-03-27 16:15 ` Javier Martinez Canillas
2023-03-27 16:15 ` Javier Martinez Canillas
2023-03-27 17:48 ` Ondřej Jirman
2023-03-27 17:48 ` Ondřej Jirman
2023-03-27 17:48 ` Ondřej Jirman
2023-03-27 18:15 ` Javier Martinez Canillas
2023-03-27 18:15 ` Javier Martinez Canillas
2023-03-27 18:15 ` Javier Martinez Canillas
2023-03-27 19:45 ` Ondřej Jirman
2023-03-27 19:45 ` Ondřej Jirman
2023-03-27 19:45 ` Ondřej Jirman
2023-03-28 3:08 ` Javier Martinez Canillas
2023-03-28 3:08 ` Javier Martinez Canillas
2023-03-28 3:08 ` Javier Martinez Canillas
2023-03-27 16:50 ` Ondřej Jirman
2023-03-27 16:50 ` Ondřej Jirman
2023-03-27 16:50 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8197476.T7Z3S40VBb@diego \
--to=heiko@sntech.de \
--cc=ayufan@ayufan.eu \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=javierm@redhat.com \
--cc=kc@postmarketos.org \
--cc=kernel@undef.tools \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pbrobinson@gmail.com \
--cc=robert.mader@collabora.com \
--cc=robh+dt@kernel.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.