All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: qixiaoyu1 <qxy65535@gmail.com>
Cc: qixiaoyu1 <qixiaoyu1@xiaomi.com>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	liuchao12@xiaomi.com, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] resize.f2fs: add option to manually specify new overprovision
Date: Wed, 22 Jun 2022 21:19:46 +0800	[thread overview]
Message-ID: <81ebfa7d-e294-409c-a3a6-5acb6daeb03f@kernel.org> (raw)
In-Reply-To: <20220620084810.24885-1-qixiaoyu1@xiaomi.com>

On 2022/6/20 16:48, qixiaoyu1 wrote:
> From: liuchao12 <liuchao12@xiaomi.com>
> 
> Make.f2fs supports manually specifying overprovision, and we expect
> resize.f2fs to support it as well.
> 
> This change add a new '-o' option to manually specify overprovision,
> and fix to check free space before grow. Otherwise, after grow,
> kernel may report below error message when we mount the image if -o
> parameter is specified during resize:
> 
> F2FS-fs (loop0): invalid crc_offset: 0
> F2FS-fs (loop0): Wrong valid_user_blocks: 16404, user_block_count: 13312
> F2FS-fs (loop0): Failed to get valid F2FS checkpoint
> mount(2) system call failed: Structure needs cleaning.
> 
> Signed-off-by: qixiaoyu1 <qixiaoyu1@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: qixiaoyu1 <qxy65535@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, liuchao12@xiaomi.com,
	qixiaoyu1 <qixiaoyu1@xiaomi.com>
Subject: Re: [PATCH v2] resize.f2fs: add option to manually specify new overprovision
Date: Wed, 22 Jun 2022 21:19:46 +0800	[thread overview]
Message-ID: <81ebfa7d-e294-409c-a3a6-5acb6daeb03f@kernel.org> (raw)
In-Reply-To: <20220620084810.24885-1-qixiaoyu1@xiaomi.com>

On 2022/6/20 16:48, qixiaoyu1 wrote:
> From: liuchao12 <liuchao12@xiaomi.com>
> 
> Make.f2fs supports manually specifying overprovision, and we expect
> resize.f2fs to support it as well.
> 
> This change add a new '-o' option to manually specify overprovision,
> and fix to check free space before grow. Otherwise, after grow,
> kernel may report below error message when we mount the image if -o
> parameter is specified during resize:
> 
> F2FS-fs (loop0): invalid crc_offset: 0
> F2FS-fs (loop0): Wrong valid_user_blocks: 16404, user_block_count: 13312
> F2FS-fs (loop0): Failed to get valid F2FS checkpoint
> mount(2) system call failed: Structure needs cleaning.
> 
> Signed-off-by: qixiaoyu1 <qixiaoyu1@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

  reply	other threads:[~2022-06-22 13:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 11:49 [f2fs-dev] [PATCH 1/2] resize.f2fs: add option to manually specify new overprovision qixiaoyu1
2022-06-14 11:49 ` qixiaoyu1
2022-06-14 11:49 ` [f2fs-dev] [PATCH 2/2] f2fs-tools: fix to check free space before grow qixiaoyu1
2022-06-14 11:49   ` qixiaoyu1
2022-06-19  0:10   ` [f2fs-dev] " Chao Yu
2022-06-19  0:10     ` Chao Yu
2022-06-19  0:01 ` [f2fs-dev] [PATCH 1/2] resize.f2fs: add option to manually specify new overprovision Chao Yu
2022-06-19  0:01   ` Chao Yu
2022-06-20  8:48   ` [f2fs-dev] [PATCH v2] " qixiaoyu1
2022-06-20  8:48     ` qixiaoyu1
2022-06-22 13:19     ` Chao Yu [this message]
2022-06-22 13:19       ` Chao Yu
2022-06-20 11:56   ` [f2fs-dev] [PATCH v3 1/2] " qixiaoyu1
2022-06-20 11:56     ` qixiaoyu1
2022-06-20 11:56     ` [f2fs-dev] [PATCH v3 2/2] resize.f2fs: update man page for options -i, -s and -V qixiaoyu1
2022-06-20 11:56       ` qixiaoyu1
2022-06-22 13:21       ` [f2fs-dev] " Chao Yu
2022-06-22 13:21         ` Chao Yu
2022-06-22 18:31         ` [f2fs-dev] " Jaegeuk Kim
2022-06-22 18:31           ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81ebfa7d-e294-409c-a3a6-5acb6daeb03f@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuchao12@xiaomi.com \
    --cc=qixiaoyu1@xiaomi.com \
    --cc=qxy65535@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.