From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aman Kumar Pandey <aman.kumarpandey@nxp.com>,
linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org,
alexandre.belloni@bootlin.com, krzk+dt@kernel.org,
robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Cc: vikash.bansal@nxp.com, priyanka.jain@nxp.com,
shashank.rebbapragada@nxp.com, Frank.Li@nxp.com
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
Date: Wed, 12 Feb 2025 17:49:25 +0100 [thread overview]
Message-ID: <822d6dca-b2c6-4439-ade5-219620ebc435@kernel.org> (raw)
In-Reply-To: <20250212132227.1348374-1-aman.kumarpandey@nxp.com>
On 12/02/2025 14:22, Aman Kumar Pandey wrote:
> P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) is multiport I3C hub
> device which connects to a host CPU via I3C/I2C/SMBus bus on one
> side and to multiple peripheral devices on the other side.
>
> Signed-off-by: Aman Kumar Pandey <aman.kumarpandey@nxp.com>
> Signed-off-by: Vikash Bansal <vikash.bansal@nxp.com>
> ---
> .../bindings/i3c/p3h2x4x_i3c_hub.yaml | 404 ++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 411 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml b/Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml
> new file mode 100644
> index 000000000000..33ea524e5432
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml
Nothing here looks like being even close to existing coding style. Look
how other files are written, including file naming, blank lines, style
of properties and entire layout.
Your current code is not only unreadable but also incorrect. But due to
unreadability, I won't waste time to review.
You should have make internal review of all this.
> L: linux-hwmon@vger.kernel.org
Best regards,
Krzysztof
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aman Kumar Pandey <aman.kumarpandey@nxp.com>,
linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org,
alexandre.belloni@bootlin.com, krzk+dt@kernel.org,
robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Cc: vikash.bansal@nxp.com, priyanka.jain@nxp.com,
shashank.rebbapragada@nxp.com, Frank.Li@nxp.com
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
Date: Wed, 12 Feb 2025 17:49:25 +0100 [thread overview]
Message-ID: <822d6dca-b2c6-4439-ade5-219620ebc435@kernel.org> (raw)
In-Reply-To: <20250212132227.1348374-1-aman.kumarpandey@nxp.com>
On 12/02/2025 14:22, Aman Kumar Pandey wrote:
> P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) is multiport I3C hub
> device which connects to a host CPU via I3C/I2C/SMBus bus on one
> side and to multiple peripheral devices on the other side.
>
> Signed-off-by: Aman Kumar Pandey <aman.kumarpandey@nxp.com>
> Signed-off-by: Vikash Bansal <vikash.bansal@nxp.com>
> ---
> .../bindings/i3c/p3h2x4x_i3c_hub.yaml | 404 ++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 411 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml b/Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml
> new file mode 100644
> index 000000000000..33ea524e5432
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/p3h2x4x_i3c_hub.yaml
Nothing here looks like being even close to existing coding style. Look
how other files are written, including file naming, blank lines, style
of properties and entire layout.
Your current code is not only unreadable but also incorrect. But due to
unreadability, I won't waste time to review.
You should have make internal review of all this.
> L: linux-hwmon@vger.kernel.org
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-12 17:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 13:22 [PATCH 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Aman Kumar Pandey
2025-02-12 13:22 ` Aman Kumar Pandey
2025-02-12 13:22 ` [PATCH 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-hub device Aman Kumar Pandey
2025-02-12 13:22 ` Aman Kumar Pandey
2025-02-12 16:42 ` Frank Li
2025-02-12 16:42 ` Frank Li
2025-02-12 16:53 ` Krzysztof Kozlowski
2025-02-12 16:53 ` Krzysztof Kozlowski
2025-02-12 18:20 ` Alexandre Belloni
2025-02-12 18:20 ` Alexandre Belloni
2025-02-13 11:49 ` kernel test robot
2025-02-13 11:49 ` kernel test robot
2025-02-13 17:46 ` kernel test robot
2025-02-13 17:46 ` kernel test robot
2025-02-14 4:21 ` kernel test robot
2025-02-14 4:21 ` kernel test robot
2025-02-16 15:17 ` Dan Carpenter
2025-02-16 15:17 ` Dan Carpenter
2025-02-19 4:52 ` kernel test robot
2025-02-19 4:52 ` kernel test robot
2025-02-12 15:25 ` [PATCH 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Rob Herring (Arm)
2025-02-12 15:25 ` Rob Herring (Arm)
2025-02-12 16:23 ` Frank Li
2025-02-12 16:23 ` Frank Li
2025-02-12 16:49 ` Krzysztof Kozlowski [this message]
2025-02-12 16:49 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-02-13 2:59 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=822d6dca-b2c6-4439-ade5-219620ebc435@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aman.kumarpandey@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=priyanka.jain@nxp.com \
--cc=robh@kernel.org \
--cc=shashank.rebbapragada@nxp.com \
--cc=vikash.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.