All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] Fix sti drivers whcih mix reg address spaces
Date: Mon, 01 Dec 2014 16:36:51 +0100	[thread overview]
Message-ID: <8237128.RmunIxMfYX@wuerfel> (raw)
In-Reply-To: <1416385632-5832-1-git-send-email-peter.griffin@linaro.org>

On Wednesday 19 November 2014 08:27:05 Peter Griffin wrote:
> Hi,
> 
> Following on from Arnds comments about the picophy driver here
> https://lkml.org/lkml/2014/11/13/161, this series fixes the
> remaining upstreamed drivers for STI, which are mixing address spaces
> in the reg property. We do this in a way similar to the keystone
> and bcm7445 platforms, by having sysconfig phandle/ offset pair (
> where only one register is required). Or phandle / integer array
> where multiple offsets in the same bank are needed).
> 
> This series breaks DT compatability! But the platform support
> is WIP and only being used by the few developers who are upstreaming
> support for it. I've made each change to the driver / dt doc / dt
> file as a single atomic commit so the kernel will remain bisectable. 
> 
> This series then also enables the picophy driver, and adds back in
> the ehci/ohci dt nodes for stih410 which make use of the picophy.

This all looks very good to me, nice work!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

I have one comment for patch 4, but I don't have a good solution for
that, hopefully someone on the devicetree-discuss list has some insight,
otherwise we just keep your version.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	maxime.coquelin-qxv4g6HH51o@public.gmane.org,
	patrice.chotard-qxv4g6HH51o@public.gmane.org,
	peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
	kishon-l0cyMroinI0@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alexandre.torgue-qxv4g6HH51o@public.gmane.org
Subject: Re: [PATCH 0/7] Fix sti drivers whcih mix reg address spaces
Date: Mon, 01 Dec 2014 16:36:51 +0100	[thread overview]
Message-ID: <8237128.RmunIxMfYX@wuerfel> (raw)
In-Reply-To: <1416385632-5832-1-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

On Wednesday 19 November 2014 08:27:05 Peter Griffin wrote:
> Hi,
> 
> Following on from Arnds comments about the picophy driver here
> https://lkml.org/lkml/2014/11/13/161, this series fixes the
> remaining upstreamed drivers for STI, which are mixing address spaces
> in the reg property. We do this in a way similar to the keystone
> and bcm7445 platforms, by having sysconfig phandle/ offset pair (
> where only one register is required). Or phandle / integer array
> where multiple offsets in the same bank are needed).
> 
> This series breaks DT compatability! But the platform support
> is WIP and only being used by the few developers who are upstreaming
> support for it. I've made each change to the driver / dt doc / dt
> file as a single atomic commit so the kernel will remain bisectable. 
> 
> This series then also enables the picophy driver, and adds back in
> the ehci/ohci dt nodes for stih410 which make use of the picophy.

This all looks very good to me, nice work!

Reviewed-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

I have one comment for patch 4, but I don't have a good solution for
that, hopefully someone on the devicetree-discuss list has some insight,
otherwise we just keep your version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
	maxime.coquelin@st.com, patrice.chotard@st.com,
	peppe.cavallaro@st.com, kishon@ti.com, lee.jones@linaro.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	alexandre.torgue@st.com
Subject: Re: [PATCH 0/7] Fix sti drivers whcih mix reg address spaces
Date: Mon, 01 Dec 2014 16:36:51 +0100	[thread overview]
Message-ID: <8237128.RmunIxMfYX@wuerfel> (raw)
In-Reply-To: <1416385632-5832-1-git-send-email-peter.griffin@linaro.org>

On Wednesday 19 November 2014 08:27:05 Peter Griffin wrote:
> Hi,
> 
> Following on from Arnds comments about the picophy driver here
> https://lkml.org/lkml/2014/11/13/161, this series fixes the
> remaining upstreamed drivers for STI, which are mixing address spaces
> in the reg property. We do this in a way similar to the keystone
> and bcm7445 platforms, by having sysconfig phandle/ offset pair (
> where only one register is required). Or phandle / integer array
> where multiple offsets in the same bank are needed).
> 
> This series breaks DT compatability! But the platform support
> is WIP and only being used by the few developers who are upstreaming
> support for it. I've made each change to the driver / dt doc / dt
> file as a single atomic commit so the kernel will remain bisectable. 
> 
> This series then also enables the picophy driver, and adds back in
> the ehci/ohci dt nodes for stih410 which make use of the picophy.

This all looks very good to me, nice work!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

I have one comment for patch 4, but I don't have a good solution for
that, hopefully someone on the devicetree-discuss list has some insight,
otherwise we just keep your version.

	Arnd

  parent reply	other threads:[~2014-12-01 15:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19  8:27 [PATCH 0/7] Fix sti drivers whcih mix reg address spaces Peter Griffin
2014-11-19  8:27 ` Peter Griffin
2014-11-19  8:27 ` Peter Griffin
2014-11-19  8:27 ` [PATCH 1/7] phy: phy-stih407-usb: Pass sysconfig register offsets via syscfg property Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19  8:27 ` [PATCH 2/7] phy: miphy365x: Pass sysconfig register offsets via syscfg dt property Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19 10:42   ` Lee Jones
2014-11-19 10:42     ` Lee Jones
2014-11-19  8:27 ` [PATCH 3/7] ARM: STi: DT: STiH407: Add usb2 picophy dt nodes Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19  8:27 ` [PATCH 4/7] ARM: STi: DT: STiH410: " Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-12-01 15:40   ` Arnd Bergmann
2014-12-01 15:40     ` Arnd Bergmann
2014-11-19  8:27 ` [PATCH 5/7] ARM: STi: DT: STiH410: Add DT nodes for the ehci and ohci usb controllers Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19  8:27 ` [PATCH 6/7] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19  8:27 ` [PATCH 7/7] stmmac: dwmac-sti: Pass sysconfig register offset via syscon dt property Peter Griffin
2014-11-19  8:27   ` Peter Griffin
2014-11-19  8:51   ` Lee Jones
2014-11-19  8:51     ` Lee Jones
2014-12-01 15:36 ` Arnd Bergmann [this message]
2014-12-01 15:36   ` [PATCH 0/7] Fix sti drivers whcih mix reg address spaces Arnd Bergmann
2014-12-01 15:36   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8237128.RmunIxMfYX@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.