From: Yi Zhang <yi.zhang@redhat.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Chao Leng <lengchao@huawei.com>
Subject: Re: [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races
Date: Tue, 20 Oct 2020 03:32:44 -0400 (EDT) [thread overview]
Message-ID: <826927458.4718534.1603179164356.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20201016142811.1262214-1-ming.lei@redhat.com>
Thanks Ming, feel free to add:
Tested-by: Yi Zhang <yi.zhang@redhat.com>
For the timeout issue, I've filed below issue to track it, thanks.
https://bugzilla.kernel.org/show_bug.cgi?id=209763
Best Regards,
Yi Zhang
----- Original Message -----
From: "Ming Lei" <ming.lei@redhat.com>
To: "Jens Axboe" <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, "Christoph Hellwig" <hch@lst.de>, "Keith Busch" <kbusch@kernel.org>
Cc: "Yi Zhang" <yi.zhang@redhat.com>, "Sagi Grimberg" <sagi@grimberg.me>, "Chao Leng" <lengchao@huawei.com>, "Ming Lei" <ming.lei@redhat.com>
Sent: Friday, October 16, 2020 10:28:07 PM
Subject: [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races
Hi,
The 1st 2 patches fixes request completion related races.
The 2nd 3 patches fixes/improves nvme-tcp error recovery.
With the 4 patches, nvme/012 can pass on nvme-tcp in Zhang Yi's test
machine.
Ming Lei (4):
blk-mq: check rq->state explicitly in
blk_mq_tagset_count_completed_rqs
blk-mq: think request as completed if it isn't IN_FLIGHT.
nvme: tcp: fix race between timeout and normal completion
nvme: tcp: complete non-IO requests atomically
block/blk-flush.c | 2 ++
block/blk-mq-tag.c | 2 +-
drivers/nvme/host/tcp.c | 76 +++++++++++++++++++++++++++++------------
include/linux/blk-mq.h | 8 ++++-
4 files changed, 65 insertions(+), 23 deletions(-)
CC: Chao Leng <lengchao@huawei.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Yi Zhang <yi.zhang@redhat.com>
--
2.25.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Yi Zhang <yi.zhang@redhat.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Chao Leng <lengchao@huawei.com>, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races
Date: Tue, 20 Oct 2020 03:32:44 -0400 (EDT) [thread overview]
Message-ID: <826927458.4718534.1603179164356.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20201016142811.1262214-1-ming.lei@redhat.com>
Thanks Ming, feel free to add:
Tested-by: Yi Zhang <yi.zhang@redhat.com>
For the timeout issue, I've filed below issue to track it, thanks.
https://bugzilla.kernel.org/show_bug.cgi?id=209763
Best Regards,
Yi Zhang
----- Original Message -----
From: "Ming Lei" <ming.lei@redhat.com>
To: "Jens Axboe" <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, "Christoph Hellwig" <hch@lst.de>, "Keith Busch" <kbusch@kernel.org>
Cc: "Yi Zhang" <yi.zhang@redhat.com>, "Sagi Grimberg" <sagi@grimberg.me>, "Chao Leng" <lengchao@huawei.com>, "Ming Lei" <ming.lei@redhat.com>
Sent: Friday, October 16, 2020 10:28:07 PM
Subject: [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races
Hi,
The 1st 2 patches fixes request completion related races.
The 2nd 3 patches fixes/improves nvme-tcp error recovery.
With the 4 patches, nvme/012 can pass on nvme-tcp in Zhang Yi's test
machine.
Ming Lei (4):
blk-mq: check rq->state explicitly in
blk_mq_tagset_count_completed_rqs
blk-mq: think request as completed if it isn't IN_FLIGHT.
nvme: tcp: fix race between timeout and normal completion
nvme: tcp: complete non-IO requests atomically
block/blk-flush.c | 2 ++
block/blk-mq-tag.c | 2 +-
drivers/nvme/host/tcp.c | 76 +++++++++++++++++++++++++++++------------
include/linux/blk-mq.h | 8 ++++-
4 files changed, 65 insertions(+), 23 deletions(-)
CC: Chao Leng <lengchao@huawei.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Yi Zhang <yi.zhang@redhat.com>
--
2.25.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-20 7:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 14:28 [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races Ming Lei
2020-10-16 14:28 ` Ming Lei
2020-10-16 14:28 ` [PATCH 1/4] blk-mq: check rq->state explicitly in blk_mq_tagset_count_completed_rqs Ming Lei
2020-10-16 14:28 ` Ming Lei
2020-10-19 0:50 ` Ming Lei
2020-10-19 0:50 ` Ming Lei
2020-10-16 14:28 ` [PATCH 2/4] blk-mq: think request as completed if it isn't IN_FLIGHT Ming Lei
2020-10-16 14:28 ` Ming Lei
2020-10-16 14:28 ` [PATCH 3/4] nvme: tcp: fix race between timeout and normal completion Ming Lei
2020-10-16 14:28 ` Ming Lei
2020-10-20 8:11 ` Sagi Grimberg
2020-10-20 8:11 ` Sagi Grimberg
2020-10-20 9:44 ` Ming Lei
2020-10-20 9:44 ` Ming Lei
2020-10-16 14:28 ` [PATCH 4/4] nvme: tcp: complete non-IO requests atomically Ming Lei
2020-10-16 14:28 ` Ming Lei
2020-10-20 8:14 ` Sagi Grimberg
2020-10-20 8:14 ` Sagi Grimberg
2020-10-20 7:32 ` Yi Zhang [this message]
2020-10-20 7:32 ` [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=826927458.4718534.1603179164356.JavaMail.zimbra@redhat.com \
--to=yi.zhang@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.