From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 3] infra: support buildroot being located in /usr
Date: Thu, 19 Jun 2014 21:42:27 +0200 [thread overview]
Message-ID: <8282245ececc13c97588.1403206947@localhost> (raw)
In-Reply-To: <patchbomb.1403206946@localhost>
pkg-generic and pkg-autotools both perform sed replacements of /usr to
$(STAGING_DIR)/usr, in .pc and .la files respectively. However, if buildroot
itself is located in /usr, then STAGING_DIR also starts with /usr, and naive
replacements of '/usr' can result in paths of the form:
/usr/buildroot/.../sysroot/usr/buildroot/.../sysroot/...
This patch makes the replacements more careful, by first replacing the known
paths BASE_DIR and STAGING_DIR to tokens, then performing the actual
replacement, and finally replacing the tokens with the corresponding paths.
Additionally it removes the unnecessary making of a backup copy in
pkg-autotools.
Partially fixes bug #5750 (https://bugs.busybox.net/show_bug.cgi?id=5750)
Partially-based-on-a-patch-from: Jeremy Kerr <benstoltz@gmail.com>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/pkg-autotools.mk | 8 ++++++--
package/pkg-generic.mk | 10 +++++++---
2 files changed, 13 insertions(+), 5 deletions(-)
diff -r a59338f65a46 -r 8282245ececc package/pkg-autotools.mk
--- a/package/pkg-autotools.mk Wed Jun 18 20:22:00 2014 +0400
+++ b/package/pkg-autotools.mk Thu Jun 19 21:41:02 2014 +0200
@@ -268,8 +268,12 @@
define $(2)_INSTALL_STAGING_CMDS
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_INSTALL_STAGING_OPT) -C $$($$(PKG)_SRCDIR)
for i in $$$$(find $$(STAGING_DIR)/usr/lib* -name "*.la"); do \
- cp -f $$$$i $$$$i~; \
- $$(SED) "s:\(['= ]\)/usr:\\1$$(STAGING_DIR)/usr:g" $$$$i; \
+ $$(SED) "s:$$(BASE_DIR):@BASE_DIR@:g" \
+ -e "s:$$(STAGING_DIR):@STAGING_DIR@:g" \
+ -e "s:\(['= ]\)/usr:\\1 at STAGING_DIR@/usr:g" \
+ -e "s:@STAGING_DIR@:$$(STAGING_DIR):g" \
+ -e "s:@BASE_DIR@:$$(BASE_DIR):g" \
+ $$$$i; \
done
endef
endif
diff -r a59338f65a46 -r 8282245ececc package/pkg-generic.mk
--- a/package/pkg-generic.mk Wed Jun 18 20:22:00 2014 +0400
+++ b/package/pkg-generic.mk Thu Jun 19 21:41:02 2014 +0200
@@ -201,9 +201,13 @@
$(foreach hook,$($(PKG)_POST_INSTALL_STAGING_HOOKS),$(call $(hook))$(sep))
$(Q)if test -n "$($(PKG)_CONFIG_SCRIPTS)" ; then \
$(call MESSAGE,"Fixing package configuration files") ;\
- $(SED) "s,^\(exec_\)\?prefix=.*,\1prefix=$(STAGING_DIR)/usr,g" \
- -e "s,-I/usr/,-I$(STAGING_DIR)/usr/,g" \
- -e "s,-L/usr/,-L$(STAGING_DIR)/usr/,g" \
+ $(SED) "s,$(BASE_DIR), at BASE_DIR@,g" \
+ -e "s,$(STAGING_DIR), at STAGING_DIR@,g" \
+ -e "s,^\(exec_\)\?prefix=.*,\1prefix=@STAGING_DIR@/usr,g" \
+ -e "s,-I/usr/,-I at STAGING_DIR@/usr/,g" \
+ -e "s,-L/usr/,-L at STAGING_DIR@/usr/,g" \
+ -e "s, at STAGING_DIR@,$(STAGING_DIR),g" \
+ -e "s, at BASE_DIR@,$(BASE_DIR),g" \
$(addprefix $(STAGING_DIR)/usr/bin/,$($(PKG)_CONFIG_SCRIPTS)) ;\
fi
$(Q)touch $@
next prev parent reply other threads:[~2014-06-19 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 19:42 [Buildroot] [PATCH 0 of 3] Support buildroot being located in /usr Thomas De Schampheleire
2014-06-19 19:42 ` Thomas De Schampheleire [this message]
2014-06-20 11:41 ` [Buildroot] [PATCH 1 of 3] infra: support " Thomas De Schampheleire
2014-06-19 19:42 ` [Buildroot] [PATCH 2 of 3] qt5: " Thomas De Schampheleire
2014-06-19 19:42 ` [Buildroot] [PATCH 3 of 3] pkgconf: don't double prefix lib/include paths with sysroot Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8282245ececc13c97588.1403206947@localhost \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.