From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 3] qt5: support buildroot being located in /usr
Date: Thu, 19 Jun 2014 21:42:28 +0200 [thread overview]
Message-ID: <9bbc6f00bb24ba682d88.1403206948@localhost> (raw)
In-Reply-To: <patchbomb.1403206946@localhost>
qt5 performs sed replacements of /usr to $(STAGING_DIR)/usr in .la files.
However, if buildroot itself is located in /usr, then STAGING_DIR also
starts with /usr, and naive replacements of '/usr' can result in paths of
the form:
/usr/buildroot/.../sysroot/usr/buildroot/.../sysroot/...
This patch makes the replacements more careful, by first replacing the known
paths BASE_DIR and STAGING_DIR to tokens, then performing the actual
replacement, and finally replacing the tokens with the corresponding paths.
Partially fixes bug #5750 (https://bugs.busybox.net/show_bug.cgi?id=5750)
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/qt5/qt5.mk | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff -r 8282245ececc -r 9bbc6f00bb24 package/qt5/qt5.mk
--- a/package/qt5/qt5.mk Thu Jun 19 21:41:02 2014 +0200
+++ b/package/qt5/qt5.mk Thu Jun 19 21:16:12 2014 +0200
@@ -5,7 +5,12 @@
define QT5_LA_PRL_FILES_FIXUP
for i in $$(find $(STAGING_DIR)/usr/lib* -name "libQt5*.la"); do \
- $(SED) "s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$i; \
+ $(SED) "s:$(BASE_DIR):@BASE_DIR@:g" \
+ -e "s:$(STAGING_DIR):@STAGING_DIR@:g" \
+ -e "s:\(['= ]\)/usr:\\1 at STAGING_DIR@/usr:g" \
+ -e "s:@STAGING_DIR@:$(STAGING_DIR):g" \
+ -e "s:@BASE_DIR@:$(BASE_DIR):g" \
+ $$i ; \
$(SED) "/^dependency_libs=/s%-L/usr/lib %%g" $$i ; \
done
for i in $$(find $(STAGING_DIR)/usr/lib* -name "libQt5*.prl"); do \
next prev parent reply other threads:[~2014-06-19 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 19:42 [Buildroot] [PATCH 0 of 3] Support buildroot being located in /usr Thomas De Schampheleire
2014-06-19 19:42 ` [Buildroot] [PATCH 1 of 3] infra: support " Thomas De Schampheleire
2014-06-20 11:41 ` Thomas De Schampheleire
2014-06-19 19:42 ` Thomas De Schampheleire [this message]
2014-06-19 19:42 ` [Buildroot] [PATCH 3 of 3] pkgconf: don't double prefix lib/include paths with sysroot Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bbc6f00bb24ba682d88.1403206948@localhost \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.