From: "Michael Walle" <michael@walle.cc>
To: "Paolo Bonzini" <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, michael@walle.cc, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] lm32: remove unused function
Date: Mon, 4 Mar 2013 21:59:05 +0100 [thread overview]
Message-ID: <828e143ca9f4a2330bb1ef35738fa187.squirrel@ssl.serverraum.org> (raw)
In-Reply-To: <1362417107-27069-1-git-send-email-pbonzini@redhat.com>
On Mon, March 4, 2013 18:11, Paolo Bonzini wrote:
> The milkymist-minimac device in fact does not exist at all.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael Walle <michael@walle.cc>
> ---
> hw/milkymist-hw.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/hw/milkymist-hw.h b/hw/milkymist-hw.h
> index c8bd7e9..5def311 100644
> --- a/hw/milkymist-hw.h
> +++ b/hw/milkymist-hw.h
> @@ -170,22 +170,6 @@ static inline DeviceState
> *milkymist_ac97_create(hwaddr base,
> return dev;
> }
>
> -static inline DeviceState *milkymist_minimac_create(hwaddr base,
> - qemu_irq rx_irq, qemu_irq tx_irq)
> -{
> - DeviceState *dev;
> -
> - qemu_check_nic_model(&nd_table[0], "minimac");
> - dev = qdev_create(NULL, "milkymist-minimac");
> - qdev_set_nic_properties(dev, &nd_table[0]);
> - qdev_init_nofail(dev);
> - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
> - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, rx_irq);
> - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, tx_irq);
> -
> - return dev;
> -}
> -
> static inline DeviceState *milkymist_minimac2_create(hwaddr base,
> hwaddr buffers_base, qemu_irq rx_irq, qemu_irq tx_irq)
> {
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <michael@walle.cc>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, michael@walle.cc, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] lm32: remove unused function
Date: Mon, 4 Mar 2013 21:59:05 +0100 [thread overview]
Message-ID: <828e143ca9f4a2330bb1ef35738fa187.squirrel@ssl.serverraum.org> (raw)
In-Reply-To: <1362417107-27069-1-git-send-email-pbonzini@redhat.com>
On Mon, March 4, 2013 18:11, Paolo Bonzini wrote:
> The milkymist-minimac device in fact does not exist at all.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael Walle <michael@walle.cc>
> ---
> hw/milkymist-hw.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/hw/milkymist-hw.h b/hw/milkymist-hw.h
> index c8bd7e9..5def311 100644
> --- a/hw/milkymist-hw.h
> +++ b/hw/milkymist-hw.h
> @@ -170,22 +170,6 @@ static inline DeviceState
> *milkymist_ac97_create(hwaddr base,
> return dev;
> }
>
> -static inline DeviceState *milkymist_minimac_create(hwaddr base,
> - qemu_irq rx_irq, qemu_irq tx_irq)
> -{
> - DeviceState *dev;
> -
> - qemu_check_nic_model(&nd_table[0], "minimac");
> - dev = qdev_create(NULL, "milkymist-minimac");
> - qdev_set_nic_properties(dev, &nd_table[0]);
> - qdev_init_nofail(dev);
> - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
> - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, rx_irq);
> - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 1, tx_irq);
> -
> - return dev;
> -}
> -
> static inline DeviceState *milkymist_minimac2_create(hwaddr base,
> hwaddr buffers_base, qemu_irq rx_irq, qemu_irq tx_irq)
> {
next prev parent reply other threads:[~2013-03-04 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 17:11 [Qemu-trivial] [PATCH] lm32: remove unused function Paolo Bonzini
2013-03-04 17:11 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 20:59 ` Michael Walle [this message]
2013-03-04 20:59 ` Michael Walle
2013-03-08 9:18 ` [Qemu-trivial] " Stefan Hajnoczi
2013-03-08 9:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=828e143ca9f4a2330bb1ef35738fa187.squirrel@ssl.serverraum.org \
--to=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.