All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@mailbox.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Rokosov <ddrokosov@sberdevices.ru>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format
Date: Wed, 09 Aug 2023 20:44:00 +0200	[thread overview]
Message-ID: <8294548.NyiUUSuA9g@kongar> (raw)
In-Reply-To: <a48b1a97-2286-d2f9-742e-d718adcf1eed@linaro.org>

Hi,

Am Mittwoch, 9. August 2023, 15:02:23 CEST schrieb Krzysztof Kozlowski:
> On 09/08/2023 08:58, Jerome Brunet wrote:
> >>> +      required:
> >>> +        - '#reset-cells'
> >>
> >> else:
> >>   properties:
> >>     '#reset-cells': false
> >> ???
> >>
> >>
> >> You need to constrain the clocks per variant. Probably names are also
> >> specific to each one, so the list of names can be moved here and you
> >> keep just min/maxItems in the top level property.
> >>
> > 
> > input clock names and constraints are the same for all 3 variants.
> 
> Then why do you have this huge, apparently unnecessary, oneOf? If it's
> the same, then drop the oneOf and make number of clocks fixed.

But as far as I understand the number of clocks is not fixed. As Jerome pointed 
out in the other post, it can have any combination of clocks and range from 1 
up to 11, where 'pclk' is always 1st clock.
I currently have no idea how to constraint that, despite limiting the number 
of clock-names.

Best regards,
Alexander



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@mailbox.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Rokosov <ddrokosov@sberdevices.ru>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format
Date: Wed, 09 Aug 2023 20:44:00 +0200	[thread overview]
Message-ID: <8294548.NyiUUSuA9g@kongar> (raw)
In-Reply-To: <a48b1a97-2286-d2f9-742e-d718adcf1eed@linaro.org>

Hi,

Am Mittwoch, 9. August 2023, 15:02:23 CEST schrieb Krzysztof Kozlowski:
> On 09/08/2023 08:58, Jerome Brunet wrote:
> >>> +      required:
> >>> +        - '#reset-cells'
> >>
> >> else:
> >>   properties:
> >>     '#reset-cells': false
> >> ???
> >>
> >>
> >> You need to constrain the clocks per variant. Probably names are also
> >> specific to each one, so the list of names can be moved here and you
> >> keep just min/maxItems in the top level property.
> >>
> > 
> > input clock names and constraints are the same for all 3 variants.
> 
> Then why do you have this huge, apparently unnecessary, oneOf? If it's
> the same, then drop the oneOf and make number of clocks fixed.

But as far as I understand the number of clocks is not fixed. As Jerome pointed 
out in the other post, it can have any combination of clocks and range from 1 
up to 11, where 'pclk' is always 1st clock.
I currently have no idea how to constraint that, despite limiting the number 
of clock-names.

Best regards,
Alexander



  parent reply	other threads:[~2023-08-09 18:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 19:48 [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format Alexander Stein
2023-08-08 19:48 ` Alexander Stein
2023-08-09  6:15 ` Jerome Brunet
2023-08-09  6:15   ` Jerome Brunet
2023-08-09 18:37   ` Alexander Stein
2023-08-09 18:37     ` Alexander Stein
2023-08-09  6:38 ` Krzysztof Kozlowski
2023-08-09  6:38   ` Krzysztof Kozlowski
2023-08-09  6:58   ` Jerome Brunet
2023-08-09  6:58     ` Jerome Brunet
2023-08-09 13:02     ` Krzysztof Kozlowski
2023-08-09 13:02       ` Krzysztof Kozlowski
2023-08-09 13:46       ` Jerome Brunet
2023-08-09 13:46         ` Jerome Brunet
2023-08-09 14:23         ` Krzysztof Kozlowski
2023-08-09 14:23           ` Krzysztof Kozlowski
2023-08-09 18:44       ` Alexander Stein [this message]
2023-08-09 18:44         ` Alexander Stein
2023-08-10  6:11         ` Krzysztof Kozlowski
2023-08-10  6:11           ` Krzysztof Kozlowski
2023-08-10  7:32           ` Jerome Brunet
2023-08-10  7:32             ` Jerome Brunet
2023-08-10  7:46             ` Krzysztof Kozlowski
2023-08-10  7:46               ` Krzysztof Kozlowski
2023-08-10  7:51               ` Jerome Brunet
2023-08-10  7:51                 ` Jerome Brunet
2023-08-21 17:01                 ` Rob Herring
2023-08-21 17:01                   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8294548.NyiUUSuA9g@kongar \
    --to=alexander.stein@mailbox.org \
    --cc=conor+dt@kernel.org \
    --cc=ddrokosov@sberdevices.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.