From: Laurent Vivier <lvivier@redhat.com>
To: Marco A L Barbosa <malbarbo@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] linux-user: Add random ioctls
Date: Thu, 5 Oct 2017 12:35:05 +0200 [thread overview]
Message-ID: <82b1a00d-ea31-c76f-96bd-402828cceebf@redhat.com> (raw)
In-Reply-To: <CAHpsRN9s_qa_knpn0QRVu0UasFrx1c+nvy2rY6hHB7GvnRkCZg@mail.gmail.com>
On 05/10/2017 12:24, Marco A L Barbosa wrote:
> I doesn't look really trivial...
>
> To manage the buf field you must read buf_size and it cannot be done in
> a generic way: you must define a function to translate the buffer, use
> IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL.
>
> You should send your patch using "git send-email" or "git publish"
> instead of adding it in you email client.
>
>
> Thanks for your advices.
>
> My use case only requires support for RNDGETENTCNT... Considering that
> RNDADDENTROPY and RNDGETPOOL are non trivial, would a patch with only
> RNDGETENTCNT, RNDADDTOENTCNT, RNDZAPENTCNT and RNDCLEARPOOL be accepted?
I think you can only post what you use. If it is tested, it's better...
Thanks,
Laurent
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <lvivier@redhat.com>
To: Marco A L Barbosa <malbarbo@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls
Date: Thu, 5 Oct 2017 12:35:05 +0200 [thread overview]
Message-ID: <82b1a00d-ea31-c76f-96bd-402828cceebf@redhat.com> (raw)
In-Reply-To: <CAHpsRN9s_qa_knpn0QRVu0UasFrx1c+nvy2rY6hHB7GvnRkCZg@mail.gmail.com>
On 05/10/2017 12:24, Marco A L Barbosa wrote:
> I doesn't look really trivial...
>
> To manage the buf field you must read buf_size and it cannot be done in
> a generic way: you must define a function to translate the buffer, use
> IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL.
>
> You should send your patch using "git send-email" or "git publish"
> instead of adding it in you email client.
>
>
> Thanks for your advices.
>
> My use case only requires support for RNDGETENTCNT... Considering that
> RNDADDENTROPY and RNDGETPOOL are non trivial, would a patch with only
> RNDGETENTCNT, RNDADDTOENTCNT, RNDZAPENTCNT and RNDCLEARPOOL be accepted?
I think you can only post what you use. If it is tested, it's better...
Thanks,
Laurent
next prev parent reply other threads:[~2017-10-05 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 22:06 [Qemu-trivial] [PATCH] linux-user: Add random ioctls Marco A L Barbosa
2017-10-04 22:06 ` [Qemu-devel] " Marco A L Barbosa
2017-10-05 7:12 ` [Qemu-trivial] " Laurent Vivier
2017-10-05 7:12 ` [Qemu-devel] " Laurent Vivier
2017-10-05 10:24 ` Marco A L Barbosa
2017-10-05 10:24 ` [Qemu-devel] " Marco A L Barbosa
2017-10-05 10:35 ` Laurent Vivier [this message]
2017-10-05 10:35 ` Laurent Vivier
2017-10-05 13:22 ` Marco A L Barbosa
2017-10-05 13:22 ` [Qemu-devel] " Marco A L Barbosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b1a00d-ea31-c76f-96bd-402828cceebf@redhat.com \
--to=lvivier@redhat.com \
--cc=malbarbo@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.