From: "\"Stéphane Viau\"" <sviau@codeaurora.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Beeresh Gopal <gbeeresh@codeaurora.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/msm: Support NV12MT format in mdp4
Date: Fri, 13 Mar 2015 09:51:11 -0500 [thread overview]
Message-ID: <82b1d9a983a2d2fc01414022775e3e43.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <CAKMK7uHwp2-m=tcw4vnY+27jfXUDQnMdi9FOL3kQmfb1qo7=WA@mail.gmail.com>
Hi Daniel,
> On Fri, Feb 20, 2015 at 3:42 PM, Beeresh Gopal <gbeeresh@codeaurora.org>
> wrote:
>> +/* Samsung framebuffer modifiers */
>> +
>> +/*
>> + * NV12 64x32 Tiled
>> + *
>> + * 2 planes Y and CbCr, grouped into 64x32 macro tiles,
>> + * with a non-standard order in memory (Z-shape).
>> + *
>> + * Pixel layout identical to DRM_FORMAT_NV21 format:
>> + * index 0 = Y plane, [7:0] Y
>> + * index 1 = Cb:Cr plane, [15:0] Cb:Cr little endian
>> + */
>> +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1)
>
> This description mixes layout information with pixel format. Strictly
> speaking you could use this for other formats, but since the
> description doesn't mention whether this is in bytes or pixels that's
> a bit awkward. Or just mandatae that this can only be used with NV12
> fourcc (and maybe add a check for that into the core drm code.
Agreed: I think /* Tiled: 64x32 pixel macroblocks */ - or something along
those lines - as a description should do the trick.
>
> Also, is this really samsung and not mpeg?
From my understanding the VENDOR is actually SAMSUNG for the following
reasons:
a) V4L2_PIX_FMT_NV12MT has been introduced[1] for the Samsung’s s5p-fimc
driver (which got renamed into exynos4-is[2])
b) A search on “V4L2_PIX_FMT_NV12MT” in the drivers folder only returns
Samsung drivers so far..
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4a3c9b4f0df43207eb0b4d0da9cb51e185506bd5
[2]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=56fa1a6a6a7da91e7ece8b01b0ae8adb2926e434
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Stéphane
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "\"Stéphane Viau\"" <sviau@codeaurora.org>
To: "Daniel Vetter" <daniel@ffwll.ch>
Cc: "Beeresh Gopal" <gbeeresh@codeaurora.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"dri-devel" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/msm: Support NV12MT format in mdp4
Date: Fri, 13 Mar 2015 09:51:11 -0500 [thread overview]
Message-ID: <82b1d9a983a2d2fc01414022775e3e43.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <CAKMK7uHwp2-m=tcw4vnY+27jfXUDQnMdi9FOL3kQmfb1qo7=WA@mail.gmail.com>
Hi Daniel,
> On Fri, Feb 20, 2015 at 3:42 PM, Beeresh Gopal <gbeeresh@codeaurora.org>
> wrote:
>> +/* Samsung framebuffer modifiers */
>> +
>> +/*
>> + * NV12 64x32 Tiled
>> + *
>> + * 2 planes Y and CbCr, grouped into 64x32 macro tiles,
>> + * with a non-standard order in memory (Z-shape).
>> + *
>> + * Pixel layout identical to DRM_FORMAT_NV21 format:
>> + * index 0 = Y plane, [7:0] Y
>> + * index 1 = Cb:Cr plane, [15:0] Cb:Cr little endian
>> + */
>> +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1)
>
> This description mixes layout information with pixel format. Strictly
> speaking you could use this for other formats, but since the
> description doesn't mention whether this is in bytes or pixels that's
> a bit awkward. Or just mandatae that this can only be used with NV12
> fourcc (and maybe add a check for that into the core drm code.
Agreed: I think /* Tiled: 64x32 pixel macroblocks */ - or something along
those lines - as a description should do the trick.
>
> Also, is this really samsung and not mpeg?
>From my understanding the VENDOR is actually SAMSUNG for the following
reasons:
a) V4L2_PIX_FMT_NV12MT has been introduced[1] for the Samsung’s s5p-fimc
driver (which got renamed into exynos4-is[2])
b) A search on “V4L2_PIX_FMT_NV12MT” in the drivers folder only returns
Samsung drivers so far..
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4a3c9b4f0df43207eb0b4d0da9cb51e185506bd5
[2]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=56fa1a6a6a7da91e7ece8b01b0ae8adb2926e434
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Stéphane
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-03-13 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:42 [PATCH 1/2] drm/msm: update generated headers Beeresh Gopal
2015-02-20 14:42 ` [PATCH 2/2] drm/msm: Support NV12MT format in mdp4 Beeresh Gopal
2015-02-20 15:26 ` Rob Clark
2015-02-20 15:26 ` Rob Clark
2015-03-13 19:12 ` [PATCH v2 0/2] drm/msm: Add support for " Stephane Viau
2015-03-13 19:12 ` [PATCH v2 1/2] drm/msm: update generated headers Stephane Viau
2015-03-13 19:12 ` Stephane Viau
2015-03-13 19:14 ` [PATCH] rnndb: " Stephane Viau
2015-03-13 19:12 ` [PATCH v2 2/2] drm/msm/mdp4: Support NV12MT format in mdp4 Stephane Viau
2015-03-13 19:12 ` Stephane Viau
2015-03-16 8:05 ` Daniel Vetter
2015-03-16 8:05 ` Daniel Vetter
2015-03-24 18:32 ` Rob Clark
2015-03-24 18:32 ` Rob Clark
2015-03-25 2:26 ` Seung-Woo Kim
2015-02-22 10:34 ` [PATCH 2/2] drm/msm: " Daniel Vetter
2015-02-22 10:34 ` Daniel Vetter
2015-03-13 14:51 ` "Stéphane Viau" [this message]
2015-03-13 14:51 ` "Stéphane Viau"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b1d9a983a2d2fc01414022775e3e43.squirrel@www.codeaurora.org \
--to=sviau@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gbeeresh@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.