* [PATCH -next] soc/tegra: fuse: Add missing DMADEVICES dependency
@ 2022-06-28 12:10 YueHaibing
2022-06-28 23:02 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2022-06-28 12:10 UTC (permalink / raw)
To: thierry.reding, jonathanh, digetx; +Cc: linux-tegra, linux-kernel, YueHaibing
WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n])
Selected by [y]:
- SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]
TEGRA20_APB_DMA depends on DMADEVICES, so SOC_TEGRA_FUSE also should depends on it
before select it.
Fixes: 19d41e5e9c68 ("soc/tegra: fuse: Add APB DMA dependency for Tegra20")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/tegra/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 5725c8ef0406..2b6ba0f798fa 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -135,6 +135,7 @@ endif
config SOC_TEGRA_FUSE
def_bool y
depends on ARCH_TEGRA
+ depends on DMADEVICES
select SOC_BUS
select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] soc/tegra: fuse: Add missing DMADEVICES dependency
2022-06-28 12:10 [PATCH -next] soc/tegra: fuse: Add missing DMADEVICES dependency YueHaibing
@ 2022-06-28 23:02 ` Dmitry Osipenko
2022-06-29 1:43 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2022-06-28 23:02 UTC (permalink / raw)
To: YueHaibing, thierry.reding, jonathanh, digetx; +Cc: linux-tegra, linux-kernel
On 6/28/22 15:10, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
> Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n])
> Selected by [y]:
> - SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]
>
> TEGRA20_APB_DMA depends on DMADEVICES, so SOC_TEGRA_FUSE also should depends on it
> before select it.
>
> Fixes: 19d41e5e9c68 ("soc/tegra: fuse: Add APB DMA dependency for Tegra20")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/soc/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index 5725c8ef0406..2b6ba0f798fa 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -135,6 +135,7 @@ endif
> config SOC_TEGRA_FUSE
> def_bool y
> depends on ARCH_TEGRA
> + depends on DMADEVICES
> select SOC_BUS
> select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
>
Since it's a problem only for the Tegra20 config, shouldn't it be:
- select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
+ select TEGRA20_APB_DMA if (ARCH_TEGRA_2x_SOC && DMADEVICES)
?
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] soc/tegra: fuse: Add missing DMADEVICES dependency
2022-06-28 23:02 ` Dmitry Osipenko
@ 2022-06-29 1:43 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2022-06-29 1:43 UTC (permalink / raw)
To: Dmitry Osipenko, thierry.reding, jonathanh, digetx
Cc: linux-tegra, linux-kernel
On 2022/6/29 7:02, Dmitry Osipenko wrote:
> On 6/28/22 15:10, YueHaibing wrote:
>> WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
>> Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n])
>> Selected by [y]:
>> - SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]
>>
>> TEGRA20_APB_DMA depends on DMADEVICES, so SOC_TEGRA_FUSE also should depends on it
>> before select it.
>>
>> Fixes: 19d41e5e9c68 ("soc/tegra: fuse: Add APB DMA dependency for Tegra20")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/soc/tegra/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
>> index 5725c8ef0406..2b6ba0f798fa 100644
>> --- a/drivers/soc/tegra/Kconfig
>> +++ b/drivers/soc/tegra/Kconfig
>> @@ -135,6 +135,7 @@ endif
>> config SOC_TEGRA_FUSE
>> def_bool y
>> depends on ARCH_TEGRA
>> + depends on DMADEVICES
>> select SOC_BUS
>> select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
>>
>
> Since it's a problem only for the Tegra20 config, shouldn't it be:
>
> - select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
> + select TEGRA20_APB_DMA if (ARCH_TEGRA_2x_SOC && DMADEVICES)
Indeed, will do this in v2.
>
> ?
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-29 1:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-28 12:10 [PATCH -next] soc/tegra: fuse: Add missing DMADEVICES dependency YueHaibing
2022-06-28 23:02 ` Dmitry Osipenko
2022-06-29 1:43 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.