* [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
@ 2020-08-11 11:18 ` Christian König
0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2020-08-11 11:18 UTC (permalink / raw)
To: peterz, mingo, will, linux-kernel, dri-devel
From: Guchun Chen <guchun.chen@amd.com>
Otherwise, braces are needed when using it.
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
include/linux/rwsem.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 7e5b2a4eb560..7a5bf5d50489 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -179,7 +179,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
do { \
typecheck(struct lockdep_map *, &(nest_lock)->dep_map); \
_down_write_nest_lock(sem, &(nest_lock)->dep_map); \
-} while (0);
+} while (0)
/*
* Take/release a lock when not the owner will release it.
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
@ 2020-08-11 11:18 ` Christian König
0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2020-08-11 11:18 UTC (permalink / raw)
To: peterz, mingo, will, linux-kernel, dri-devel
From: Guchun Chen <guchun.chen@amd.com>
Otherwise, braces are needed when using it.
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
include/linux/rwsem.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 7e5b2a4eb560..7a5bf5d50489 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -179,7 +179,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
do { \
typecheck(struct lockdep_map *, &(nest_lock)->dep_map); \
_down_write_nest_lock(sem, &(nest_lock)->dep_map); \
-} while (0);
+} while (0)
/*
* Take/release a lock when not the owner will release it.
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
2020-08-11 11:18 ` Christian König
@ 2020-08-12 8:10 ` peterz
-1 siblings, 0 replies; 8+ messages in thread
From: peterz @ 2020-08-12 8:10 UTC (permalink / raw)
To: Christian König; +Cc: mingo, will, linux-kernel, dri-devel
On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
> From: Guchun Chen <guchun.chen@amd.com>
>
> Otherwise, braces are needed when using it.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Thanks!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
@ 2020-08-12 8:10 ` peterz
0 siblings, 0 replies; 8+ messages in thread
From: peterz @ 2020-08-12 8:10 UTC (permalink / raw)
To: Christian König; +Cc: mingo, will, linux-kernel, dri-devel
On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
> From: Guchun Chen <guchun.chen@amd.com>
>
> Otherwise, braces are needed when using it.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
2020-08-12 8:10 ` peterz
@ 2020-08-12 8:36 ` Christian König
-1 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2020-08-12 8:36 UTC (permalink / raw)
To: peterz; +Cc: mingo, will, linux-kernel, dri-devel
Am 12.08.20 um 10:10 schrieb peterz@infradead.org:
> On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
>> From: Guchun Chen <guchun.chen@amd.com>
>>
>> Otherwise, braces are needed when using it.
>>
>> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
> Thanks!
Do you pick it up or can I push it through drm-misc-fixes?
If the former please let me know when it hits Linus tree since I have a
driver which contains some extra {} because of this.
Thanks,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
@ 2020-08-12 8:36 ` Christian König
0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2020-08-12 8:36 UTC (permalink / raw)
To: peterz; +Cc: mingo, will, linux-kernel, dri-devel
Am 12.08.20 um 10:10 schrieb peterz@infradead.org:
> On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
>> From: Guchun Chen <guchun.chen@amd.com>
>>
>> Otherwise, braces are needed when using it.
>>
>> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
> Thanks!
Do you pick it up or can I push it through drm-misc-fixes?
If the former please let me know when it hits Linus tree since I have a
driver which contains some extra {} because of this.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
2020-08-12 8:36 ` Christian König
@ 2020-08-12 10:36 ` peterz
-1 siblings, 0 replies; 8+ messages in thread
From: peterz @ 2020-08-12 10:36 UTC (permalink / raw)
To: christian.koenig; +Cc: mingo, will, linux-kernel, dri-devel
On Wed, Aug 12, 2020 at 10:36:14AM +0200, Christian König wrote:
> Am 12.08.20 um 10:10 schrieb peterz@infradead.org:
> > On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
> > > From: Guchun Chen <guchun.chen@amd.com>
> > >
> > > Otherwise, braces are needed when using it.
> > >
> > > Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> > > Reviewed-by: Christian König <christian.koenig@amd.com>
> > Thanks!
>
> Do you pick it up or can I push it through drm-misc-fixes?
>
> If the former please let me know when it hits Linus tree since I have a
> driver which contains some extra {} because of this.
Oh, in that case you can take it:
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
and I'll drop it from my quilt series.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock
@ 2020-08-12 10:36 ` peterz
0 siblings, 0 replies; 8+ messages in thread
From: peterz @ 2020-08-12 10:36 UTC (permalink / raw)
To: christian.koenig; +Cc: mingo, will, linux-kernel, dri-devel
On Wed, Aug 12, 2020 at 10:36:14AM +0200, Christian König wrote:
> Am 12.08.20 um 10:10 schrieb peterz@infradead.org:
> > On Tue, Aug 11, 2020 at 01:18:52PM +0200, Christian König wrote:
> > > From: Guchun Chen <guchun.chen@amd.com>
> > >
> > > Otherwise, braces are needed when using it.
> > >
> > > Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> > > Reviewed-by: Christian König <christian.koenig@amd.com>
> > Thanks!
>
> Do you pick it up or can I push it through drm-misc-fixes?
>
> If the former please let me know when it hits Linus tree since I have a
> driver which contains some extra {} because of this.
Oh, in that case you can take it:
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
and I'll drop it from my quilt series.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-08-12 10:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-11 11:18 [PATCH] locking/rwsem: remove redundant semicolon of down_write_nest_lock Christian König
2020-08-11 11:18 ` Christian König
2020-08-12 8:10 ` peterz
2020-08-12 8:10 ` peterz
2020-08-12 8:36 ` Christian König
2020-08-12 8:36 ` Christian König
2020-08-12 10:36 ` peterz
2020-08-12 10:36 ` peterz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.