Re: [PATCH v2] ethdev: fast path async flow API

[Thomas Monjalon <thomas@monjalon.net>]

05/02/2024 14:14, Dariusz Sosnowski:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 31/01/2024 10:35, Dariusz Sosnowski:
> > > As a result, no checks for availability of the implementation are
> > > needed at library level in data path.
> > > Any library-level validation checks in async flow API are compiled if
> > > and only if RTE_FLOW_DEBUG macro is defined.
> > 
> > How are we supposed to enable RTE_FLOW_DEBUG?
> 
> I should document it, but the idea was that it must be explicitly enabled during build,
> by adding -c_args=-DRTE_FLOW_DEBUG to meson options.
> 
> Do you think doc/guides/nics/build_and_test.rst is a good place to document this option?

Yes

> It would be documented alongside RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX.
> 
> > May it be enabled automatically if other debug option is globally enabled?
> 
> Do you mean that if buildtype is defined as debug, then RTE_FLOW_DEBUG is defined automatically?

Yes

> I think that's a good idea.

Another way of enabling it is to check
#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG