All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Dave Airlie <airlied@redhat.com>,
	Sean Paul <sean@poorly.run>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(), and vunmap()
Date: Fri, 25 Oct 2019 16:53:34 +0200	[thread overview]
Message-ID: <83a10a33-2fe8-35f4-48f7-d43d7432b520@suse.de> (raw)
In-Reply-To: <20191025133240.54ignkzxb3qpf76u@sirius.home.kraxel.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1564 bytes --]

Hi

Am 25.10.19 um 15:32 schrieb Gerd Hoffmann:
>   Hi,
> 
>>> I had a flag to set this in the initial version of the shmem helper
>>> modeled after udl, but Thomas Hellstrom brought up a question and it was
>>> dropped. The issue was beyond my understanding:
>>>
>>> [PATCH v3 0/2] drm: Add shmem GEM library
>>> https://lists.freedesktop.org/archives/dri-devel/2018-September/190001.html
>>
>> If I understand that discussion correctly, the concern was that write
>> combining and shared memory would not work well together. So you went
>> with always-cached?
>>
>> Just recently, Gerd added unconditional write combining in rev 0be8958936.
> 
> Well, it's not really added.  It's the same thing drm_gem_mmap_obj()
> does for you when you don't have a drm_gem_object_funcs.mmap callback.
> 
> But, yes, the reason this is done in the driver's mmap() callback with
> the new mmap code path is to give drivers the option to override this
> by supplying their own mmap() handler.  So going with shmem helpers +
> custom mmap callback is a reasonable approach.
> 
> HTH,

Absolutely.

Thanks everyone for the feedback.

Best regards
Thomas

>   Gerd
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Dave Airlie <airlied@redhat.com>,
	Sean Paul <sean@poorly.run>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(),  and vunmap()
Date: Fri, 25 Oct 2019 16:53:34 +0200	[thread overview]
Message-ID: <83a10a33-2fe8-35f4-48f7-d43d7432b520@suse.de> (raw)
Message-ID: <20191025145334.i_17VHBay__Fcv2is_WXFi9NkxOCt_UNSf5PJkUzqEM@z> (raw)
In-Reply-To: <20191025133240.54ignkzxb3qpf76u@sirius.home.kraxel.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1564 bytes --]

Hi

Am 25.10.19 um 15:32 schrieb Gerd Hoffmann:
>   Hi,
> 
>>> I had a flag to set this in the initial version of the shmem helper
>>> modeled after udl, but Thomas Hellstrom brought up a question and it was
>>> dropped. The issue was beyond my understanding:
>>>
>>> [PATCH v3 0/2] drm: Add shmem GEM library
>>> https://lists.freedesktop.org/archives/dri-devel/2018-September/190001.html
>>
>> If I understand that discussion correctly, the concern was that write
>> combining and shared memory would not work well together. So you went
>> with always-cached?
>>
>> Just recently, Gerd added unconditional write combining in rev 0be8958936.
> 
> Well, it's not really added.  It's the same thing drm_gem_mmap_obj()
> does for you when you don't have a drm_gem_object_funcs.mmap callback.
> 
> But, yes, the reason this is done in the driver's mmap() callback with
> the new mmap code path is to give drivers the option to override this
> by supplying their own mmap() handler.  So going with shmem helpers +
> custom mmap callback is a reasonable approach.
> 
> HTH,

Absolutely.

Thanks everyone for the feedback.

Best regards
Thomas

>   Gerd
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-10-25 14:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 14:42 [PATCH 0/5] drm/udl: Convert to generic fbdev emulation Thomas Zimmermann
2019-10-24 14:42 ` [PATCH 1/5] drm/udl: Clear BO vmapping pointer after unmapping BO memory Thomas Zimmermann
2019-10-25  7:39   ` Daniel Vetter
2019-10-24 14:42 ` [PATCH 2/5] drm/udl: Set drm_driver.gem_prime_mmap Thomas Zimmermann
2019-10-24 14:42 ` [PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(), and vunmap() Thomas Zimmermann
2019-10-25  7:40   ` Daniel Vetter
2019-10-25  7:59     ` Thomas Zimmermann
2019-10-25  7:59       ` Thomas Zimmermann
2019-10-25  9:28       ` Daniel Vetter
2019-10-25  9:28         ` Daniel Vetter
2019-10-25 10:12         ` Thomas Zimmermann
2019-10-25 10:12           ` Thomas Zimmermann
2019-10-25 11:44           ` Noralf Trønnes
2019-10-25 11:44             ` Noralf Trønnes
2019-10-25 11:47             ` Noralf Trønnes
2019-10-25 11:47               ` Noralf Trønnes
2019-10-25 12:20             ` Thomas Zimmermann
2019-10-25 12:20               ` Thomas Zimmermann
2019-10-25 13:32               ` Gerd Hoffmann
2019-10-25 14:53                 ` Thomas Zimmermann [this message]
2019-10-25 14:53                   ` Thomas Zimmermann
2019-10-25 13:44               ` Noralf Trønnes
2019-10-25 13:44                 ` Noralf Trønnes
2019-10-24 14:42 ` [PATCH 4/5] drm/udl: Map BO memory pages in unencrypted mode Thomas Zimmermann
2019-10-24 14:42 ` [PATCH 5/5] drm/udl: Replace fbdev code with generic emulation Thomas Zimmermann
2019-10-25  7:47   ` Daniel Vetter
2019-10-25  8:00     ` Daniel Vetter
2019-10-25 11:22       ` Noralf Trønnes
2019-10-25 11:44         ` Thomas Zimmermann
2019-10-25  8:08     ` Thomas Zimmermann
2019-10-25 19:10       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a10a33-2fe8-35f4-48f7-d43d7432b520@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.