From: Pekka Enberg <penberg@gmail.com>
To: Olof Johansson <olof@austin.ibm.com>
Cc: akpm@osdl.org, trini@kernel.crashing.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
penberg@cs.helsinki.fi, paulus@samba.org, hpa@zytor.com,
linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH] PPC/PPC64: Introduce CPU_HAS_FEATURE() macro
Date: Fri, 4 Feb 2005 10:17:48 +0200 [thread overview]
Message-ID: <84144f0205020400172d89eddf@mail.gmail.com> (raw)
In-Reply-To: <20050204072254.GA17565@austin.ibm.com>
Hi,
On Fri, 4 Feb 2005 01:22:54 -0600, Olof Johansson <olof@austin.ibm.com> wrote:
> +#define CPU_HAS_FEATURE(x) (cur_cpu_spec->cpu_features & CPU_FTR_##x)
> +
Please drop the CPU_FTR_##x macro magic as it makes grepping more
complicated. If the enum names are too long, just do s/CPU_FTR_/CPU_/g
or something similar. Also, could you please make this a static inline
function?
Pekka
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@gmail.com>
To: Olof Johansson <olof@austin.ibm.com>
Cc: linuxppc64-dev@ozlabs.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org,
trini@kernel.crashing.org, benh@kernel.crashing.org,
hpa@zytor.com, akpm@osdl.org, penberg@cs.helsinki.fi
Subject: Re: [PATCH] PPC/PPC64: Introduce CPU_HAS_FEATURE() macro
Date: Fri, 4 Feb 2005 10:17:48 +0200 [thread overview]
Message-ID: <84144f0205020400172d89eddf@mail.gmail.com> (raw)
In-Reply-To: <20050204072254.GA17565@austin.ibm.com>
Hi,
On Fri, 4 Feb 2005 01:22:54 -0600, Olof Johansson <olof@austin.ibm.com> wrote:
> +#define CPU_HAS_FEATURE(x) (cur_cpu_spec->cpu_features & CPU_FTR_##x)
> +
Please drop the CPU_FTR_##x macro magic as it makes grepping more
complicated. If the enum names are too long, just do s/CPU_FTR_/CPU_/g
or something similar. Also, could you please make this a static inline
function?
Pekka
next prev parent reply other threads:[~2005-02-04 8:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-04 7:22 [PATCH] PPC/PPC64: Introduce CPU_HAS_FEATURE() macro Olof Johansson
2005-02-04 7:22 ` Olof Johansson
2005-02-04 8:17 ` Pekka Enberg [this message]
2005-02-04 8:17 ` Pekka Enberg
2005-02-04 17:20 ` Olof Johansson
2005-02-04 17:20 ` Olof Johansson
2005-02-05 7:48 ` Pekka Enberg
2005-02-05 7:48 ` Pekka Enberg
2005-02-05 9:08 ` Benjamin Herrenschmidt
2005-02-05 9:08 ` Benjamin Herrenschmidt
2005-02-04 12:36 ` Arnd Bergmann
2005-02-04 12:36 ` Arnd Bergmann
2005-02-04 18:35 ` Olof Johansson
2005-02-04 18:35 ` Olof Johansson
2005-02-04 18:57 ` Arnd Bergmann
2005-02-04 18:57 ` Arnd Bergmann
2005-02-04 23:50 ` Benjamin Herrenschmidt
2005-02-04 23:50 ` Benjamin Herrenschmidt
2005-02-04 23:49 ` Benjamin Herrenschmidt
2005-02-04 23:49 ` Benjamin Herrenschmidt
2005-02-05 0:22 ` Arnd Bergmann
2005-02-05 0:22 ` Arnd Bergmann
2005-02-05 1:34 ` Anton Blanchard
2005-02-05 1:34 ` Anton Blanchard
2005-02-05 11:04 ` Arnd Bergmann
2005-02-05 11:04 ` Arnd Bergmann
2005-02-05 1:47 ` Benjamin Herrenschmidt
2005-02-05 1:47 ` Benjamin Herrenschmidt
2005-02-04 14:45 ` Tom Rini
2005-02-04 14:45 ` Tom Rini
2005-02-05 18:46 ` [PATCH] PPC/PPC64: Abstract cpu_feature checks Olof Johansson
2005-02-05 18:46 ` Olof Johansson
2005-02-06 3:26 ` Olof Johansson
2005-02-06 3:26 ` Olof Johansson
2005-02-06 11:57 ` Arnd Bergmann
2005-02-06 11:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f0205020400172d89eddf@mail.gmail.com \
--to=penberg@gmail.com \
--cc=akpm@osdl.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=olof@austin.ibm.com \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.