Re: [OE-core] [PATCH] flac: upgrade 1.4.3 -> 1.5.0

[Michael Opdenacker <michael.opdenacker@rootcommit.com>]

Greetings,

On 3/10/25 11:24, Michael Opdenacker via lists.openembedded.org wrote:
> Hi Ross
>
> Thanks for having a look at my patch and finding out why the 
> documentation is broken.
>
> On 3/3/25 19:09, Ross Burton wrote:
>> On 27 Feb 2025, at 10:34, Michael Opdenacker via 
>> lists.openembedded.org 
>> <michael.opdenacker=rootcommit.com@lists.openembedded.org> wrote:
>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>
>>> License-Update: GFDL 1.2 -> 1.3, copyright years update
>>>
>>> Remove the do_install additional code fixing absolute paths
>>> in doc files. Such files are no longer created on 1.5.0.
>> I asked myself why these files are no longer created, and luckily the 
>> autobuilder had already done the build and comparison for me:
>>
>> https://git.yoctoproject.org/poky-buildhistory/diff/packages/cortexa15t2hf-neon-poky-linux-gnueabi/flac/flac-doc/latest?h=poky/master-next/qemuarm-alt&id=6c8904bceaa1987edffc16823c12b43e86384dea 
>>
>>
>> -PKGSIZE = 5362415
>> +PKGSIZE = 87538
>>
>> The files are no longer created because none of the documentation is 
>> installed anymore.
>>
>> This turns out to be a bug in the configure.ac script:
>>
>> https://lists.xiph.org/pipermail/flac-dev/2025-February/006698.html
>>
>> So I suggest we apply that fix and continue installing the 
>> documentation.
>
>
> Good catch, I'll take care of it.
>
>>
>> Also, whilst we’re here…
>>
>>>                 ac_cv_prog_NASM="” \
>> The nasm code was removed in 1.4.2, so you can delete this line.
>
> Great, will do it too.


I have a patch for upstream, but even though the documentation gets 
generated, there are still issues in it:
https://lists.xiph.org/pipermail/flac-dev/2025-March/006705.html

Shall I submit a new version of the recipe for 1.5.0 to allow people to 
test and use it, even if there are remaining issues in the docs?
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/