All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Ross Burton <Ross.Burton@arm.com>
Cc: michael.opdenacker@rootcommit.com,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	Peter Marko <peter.marko@siemens.com>
Subject: Re: [OE-core] [PATCH] flac: upgrade 1.4.3 -> 1.5.0
Date: Mon, 10 Mar 2025 10:24:28 +0000 (UTC)	[thread overview]
Message-ID: <ce6a8888-172a-4e24-bb26-1ab47b955b72@rootcommit.com> (raw)
In-Reply-To: <11B25FEA-816E-4B3D-A7F4-EA47A5359446@arm.com>

Hi Ross

Thanks for having a look at my patch and finding out why the 
documentation is broken.

On 3/3/25 19:09, Ross Burton wrote:
> On 27 Feb 2025, at 10:34, Michael Opdenacker via lists.openembedded.org <michael.opdenacker=rootcommit.com@lists.openembedded.org> wrote:
>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> License-Update: GFDL 1.2 -> 1.3, copyright years update
>>
>> Remove the do_install additional code fixing absolute paths
>> in doc files. Such files are no longer created on 1.5.0.
> I asked myself why these files are no longer created, and luckily the autobuilder had already done the build and comparison for me:
>
> https://git.yoctoproject.org/poky-buildhistory/diff/packages/cortexa15t2hf-neon-poky-linux-gnueabi/flac/flac-doc/latest?h=poky/master-next/qemuarm-alt&id=6c8904bceaa1987edffc16823c12b43e86384dea
>
> -PKGSIZE = 5362415
> +PKGSIZE = 87538
>
> The files are no longer created because none of the documentation is installed anymore.
>
> This turns out to be a bug in the configure.ac script:
>
> https://lists.xiph.org/pipermail/flac-dev/2025-February/006698.html
>
> So I suggest we apply that fix and continue installing the documentation.


Good catch, I'll take care of it.

>
> Also, whilst we’re here…
>
>>                 ac_cv_prog_NASM="” \
> The nasm code was removed in 1.4.2, so you can delete this line.

Great, will do it too.
More soon...
Thanks again!
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/



  reply	other threads:[~2025-03-10 10:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 10:34 [PATCH] flac: upgrade 1.4.3 -> 1.5.0 michael.opdenacker
2025-03-03 18:09 ` [OE-core] " Ross Burton
2025-03-10 10:24   ` Michael Opdenacker [this message]
2025-03-28 11:04     ` Michael Opdenacker
     [not found]   ` <182B6A0A5335D3D3.31525@lists.openembedded.org>
2025-03-16 17:38     ` Michael Opdenacker
  -- strict thread matches above, loose matches on Subject: below --
2025-03-28 21:59 michael.opdenacker
2025-03-31  8:55 ` [OE-core] " Quentin Schulz
2025-03-31  9:04   ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce6a8888-172a-4e24-bb26-1ab47b955b72@rootcommit.com \
    --to=michael.opdenacker@rootcommit.com \
    --cc=Ross.Burton@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.marko@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.