All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH 0/5] mm, highmem: kmap_atomic rework -v3
Date: Wed, 27 Oct 2010 11:27:57 +0100	[thread overview]
Message-ID: <849307$a582r7@azsmga001.ch.intel.com> (raw)
In-Reply-To: <20100918155326.478277313@chello.nl>

On Sat, 18 Sep 2010 17:53:26 +0200, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> Next version of the kmap_atomic rework using Andrew's fancy CPP trickery to
> avoid having to convert the whole tree at once.
> 
> This is compile tested for i386-allmodconfig, frv, mips-sb1250-swarm,
> powerpc-ppc6xx_defconfig, sparc32_defconfig, arm-omap3 (all with
> HIGHEM=y).

This break on x86, HIGHMEM=n:

arch/x86/mm/iomap_32.c: In function ‘kmap_atomic_prot_pfn’:
arch/x86/mm/iomap_32.c:64: error: implicit declaration of function
‘kmap_atomic_idx_push’
arch/x86/mm/iomap_32.c: In function ‘iounmap_atomic’:
arch/x86/mm/iomap_32.c:101: error: implicit declaration of function
‘kmap_atomic_idx_pop’

The use of the kmap idx there looks a little delicate so I'm not sure how
to fix this.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH 0/5] mm, highmem: kmap_atomic rework -v3
Date: Wed, 27 Oct 2010 11:27:57 +0100	[thread overview]
Message-ID: <849307$a582r7@azsmga001.ch.intel.com> (raw)
Message-ID: <20101027102757.xuUEW-w_zyJuzNV4svWfNGLINkF6qcbWUt1NusVvjXg@z> (raw)
In-Reply-To: <20100918155326.478277313@chello.nl>

On Sat, 18 Sep 2010 17:53:26 +0200, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> Next version of the kmap_atomic rework using Andrew's fancy CPP trickery to
> avoid having to convert the whole tree at once.
> 
> This is compile tested for i386-allmodconfig, frv, mips-sb1250-swarm,
> powerpc-ppc6xx_defconfig, sparc32_defconfig, arm-omap3 (all with
> HIGHEM=y).

This break on x86, HIGHMEM=n:

arch/x86/mm/iomap_32.c: In function ‘kmap_atomic_prot_pfn’:
arch/x86/mm/iomap_32.c:64: error: implicit declaration of function
‘kmap_atomic_idx_push’
arch/x86/mm/iomap_32.c: In function ‘iounmap_atomic’:
arch/x86/mm/iomap_32.c:101: error: implicit declaration of function
‘kmap_atomic_idx_pop’

The use of the kmap idx there looks a little delicate so I'm not sure how
to fix this.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH 0/5] mm, highmem: kmap_atomic rework -v3
Date: Wed, 27 Oct 2010 11:27:57 +0100	[thread overview]
Message-ID: <849307$a582r7@azsmga001.ch.intel.com> (raw)
In-Reply-To: <20100918155326.478277313@chello.nl>

On Sat, 18 Sep 2010 17:53:26 +0200, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> Next version of the kmap_atomic rework using Andrew's fancy CPP trickery to
> avoid having to convert the whole tree at once.
> 
> This is compile tested for i386-allmodconfig, frv, mips-sb1250-swarm,
> powerpc-ppc6xx_defconfig, sparc32_defconfig, arm-omap3 (all with
> HIGHEM=y).

This break on x86, HIGHMEM=n:

arch/x86/mm/iomap_32.c: In function a??kmap_atomic_prot_pfna??:
arch/x86/mm/iomap_32.c:64: error: implicit declaration of function
a??kmap_atomic_idx_pusha??
arch/x86/mm/iomap_32.c: In function a??iounmap_atomica??:
arch/x86/mm/iomap_32.c:101: error: implicit declaration of function
a??kmap_atomic_idx_popa??

The use of the kmap idx there looks a little delicate so I'm not sure how
to fix this.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-10-27 10:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-18 15:53 [PATCH 0/5] mm, highmem: kmap_atomic rework -v3 Peter Zijlstra
2010-09-18 15:53 ` Peter Zijlstra
2010-09-18 15:53 ` [PATCH 1/5] mm: strictly nested kmap_atomic Peter Zijlstra
2010-09-18 15:53   ` Peter Zijlstra
2010-09-18 15:53 ` [PATCH 2/5] mm: stack based kmap_atomic Peter Zijlstra
2010-09-18 15:53   ` Peter Zijlstra
2010-09-19 17:01   ` Linus Torvalds
2010-09-19 17:01     ` Linus Torvalds
2010-09-20  9:31     ` Peter Zijlstra
2010-09-20  9:31       ` Peter Zijlstra
2010-09-18 15:53 ` [PATCH 3/5] mm: Remove pte_*map_nested() Peter Zijlstra
2010-09-18 15:53   ` Peter Zijlstra
2010-09-18 15:53 ` [PATCH 4/5] perf, x86: Fix up kmap_atomic type Peter Zijlstra
2010-09-18 15:53   ` Peter Zijlstra
2010-09-18 15:53 ` [PATCH 5/5] mm: highmem documentation Peter Zijlstra
2010-09-18 15:53   ` Peter Zijlstra
2010-10-27 10:27 ` Chris Wilson [this message]
2010-10-27 10:27   ` [PATCH 0/5] mm, highmem: kmap_atomic rework -v3 Chris Wilson
2010-10-27 10:27   ` Chris Wilson
2010-10-27 10:33   ` [PATCH] mm,x86: fix kmap_atomic_push vs ioremap_32.c Peter Zijlstra
2010-10-27 10:33     ` Peter Zijlstra
2010-10-27 10:33     ` Peter Zijlstra
2010-10-27 11:15     ` Chris Wilson
2010-10-27 11:15       ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='849307$a582r7@azsmga001.ch.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.