From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: arm@kernel.org, soc@kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip dts64 changes for 6.15 #3
Date: Mon, 07 Apr 2025 18:40:37 +0200 [thread overview]
Message-ID: <8512245.T7Z3S40VBb@diego> (raw)
In-Reply-To: <CAL_JsqJo+9ycUFHVZ2Darh_RWaRuJGX6KKQGsbeuDWav7vKA2g@mail.gmail.com>
Hi Rob,
Am Montag, 7. April 2025, 17:56:37 Mitteleuropäische Sommerzeit schrieb Rob Herring:
> On Wed, Mar 19, 2025 at 6:56 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi soc maintainers,
> >
> > I made an error and accidentially applied a patch that was meant for
> > the mfd tree. Thankfully Stephen noticed that when the duplicate
> > commit appeared in linux-next.
>
> Both commits are in v6.15-rc1 now and the revert is not, so this
> should not get applied/pulled. Or you will need to revert the revert.
yes, that was the intention.
Back when I submitted this PR, I talked with Arnd on IRC the next day.
As both commits are identical sans some Signed-off-by lines, he suggested
not trying to put a revert in, but instead let git solve it itself, because
arnd on IRC:
> [...], but I worry that this would make things worse if 'git merge'
> ends up doing the revert on top of the original commit once it gets to
> torvalds. Not sure if that's still a problem in git these days, but
> I've seen it happen in the past.
> if two identical patches are in different branches, just leaving them
> there is usually easier
So this PR was already marked as "superseeded" in patchwork back
on march 20th.
Nevertheless, thanks for making sure no funky revert happens now.
Heiko
> > The following changes since commit 73d246b4402c3356f6b3d13665de3a51eea7b555:
> >
> > arm64: dts: rockchip: remove ethm0_clk0_25m_out from Sige5 gmac0 (2025-03-15 15:49:00 +0100)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git tags/v6.15-rockchip-dts64-3
> >
> > for you to fetch changes up to cee24bc73d4f3f47344a1a54100a69c72f1db061:
> >
> > Revert "dt-bindings: mfd: syscon: Add rk3528 QoS register compatible" (2025-03-19 00:22:18 +0100)
> >
> > ----------------------------------------------------------------
> > Revert of one commit that was applied accidentially and should instead
> > go through the MFD tree. It is already part of that tree as
> > commit 7f3e3e7228bb ("dt-bindings: mfd: syscon: Add rk3528 QoS register
> > compatible").
> >
> > ----------------------------------------------------------------
> > Heiko Stuebner (1):
> > Revert "dt-bindings: mfd: syscon: Add rk3528 QoS register compatible"
> >
> > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> >
> >
> >
>
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: arm@kernel.org, soc@kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip dts64 changes for 6.15 #3
Date: Mon, 07 Apr 2025 18:40:37 +0200 [thread overview]
Message-ID: <8512245.T7Z3S40VBb@diego> (raw)
In-Reply-To: <CAL_JsqJo+9ycUFHVZ2Darh_RWaRuJGX6KKQGsbeuDWav7vKA2g@mail.gmail.com>
Hi Rob,
Am Montag, 7. April 2025, 17:56:37 Mitteleuropäische Sommerzeit schrieb Rob Herring:
> On Wed, Mar 19, 2025 at 6:56 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi soc maintainers,
> >
> > I made an error and accidentially applied a patch that was meant for
> > the mfd tree. Thankfully Stephen noticed that when the duplicate
> > commit appeared in linux-next.
>
> Both commits are in v6.15-rc1 now and the revert is not, so this
> should not get applied/pulled. Or you will need to revert the revert.
yes, that was the intention.
Back when I submitted this PR, I talked with Arnd on IRC the next day.
As both commits are identical sans some Signed-off-by lines, he suggested
not trying to put a revert in, but instead let git solve it itself, because
arnd on IRC:
> [...], but I worry that this would make things worse if 'git merge'
> ends up doing the revert on top of the original commit once it gets to
> torvalds. Not sure if that's still a problem in git these days, but
> I've seen it happen in the past.
> if two identical patches are in different branches, just leaving them
> there is usually easier
So this PR was already marked as "superseeded" in patchwork back
on march 20th.
Nevertheless, thanks for making sure no funky revert happens now.
Heiko
> > The following changes since commit 73d246b4402c3356f6b3d13665de3a51eea7b555:
> >
> > arm64: dts: rockchip: remove ethm0_clk0_25m_out from Sige5 gmac0 (2025-03-15 15:49:00 +0100)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git tags/v6.15-rockchip-dts64-3
> >
> > for you to fetch changes up to cee24bc73d4f3f47344a1a54100a69c72f1db061:
> >
> > Revert "dt-bindings: mfd: syscon: Add rk3528 QoS register compatible" (2025-03-19 00:22:18 +0100)
> >
> > ----------------------------------------------------------------
> > Revert of one commit that was applied accidentially and should instead
> > go through the MFD tree. It is already part of that tree as
> > commit 7f3e3e7228bb ("dt-bindings: mfd: syscon: Add rk3528 QoS register
> > compatible").
> >
> > ----------------------------------------------------------------
> > Heiko Stuebner (1):
> > Revert "dt-bindings: mfd: syscon: Add rk3528 QoS register compatible"
> >
> > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> >
> >
> >
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-04-07 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 23:54 [GIT PULL] Rockchip dts64 changes for 6.15 #3 Heiko Stuebner
2025-03-19 23:54 ` Heiko Stuebner
2025-04-07 15:56 ` Rob Herring
2025-04-07 15:56 ` Rob Herring
2025-04-07 16:40 ` Heiko Stübner [this message]
2025-04-07 16:40 ` Heiko Stübner
2025-04-07 16:43 ` Rob Herring
2025-04-07 16:43 ` Rob Herring
2025-04-07 16:49 ` Heiko Stübner
2025-04-07 16:49 ` Heiko Stübner
2025-04-08 14:01 ` Rob Herring
2025-04-08 14:01 ` Rob Herring
2025-04-08 14:19 ` Heiko Stübner
2025-04-08 14:19 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8512245.T7Z3S40VBb@diego \
--to=heiko@sntech.de \
--cc=arm@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.