All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v3] ARC: [plat-hsdk]: Add reset controller node to manage ethernet reset
Date: Wed, 27 Sep 2017 10:40:20 -0700	[thread overview]
Message-ID: <85347975-edd9-7658-e2cd-7fe1436c77bb@synopsys.com> (raw)
In-Reply-To: <20170922164911.1125-1-Eugeniy.Paltsev@synopsys.com>

On 09/22/2017 09:49 AM, Eugeniy Paltsev wrote:
> DW ethernet controller on HSDK hangs sometimes after SW reset, so
> add reset node to make possible to reset DW ethernet controller HW.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> ---
> Changes v2 -> v3:
>    * Remove v1 suffix as we finaly got rid of v1 suffix in reset
>      driver and docs.
>    * Rename reset node to "reset-controller" for consistency with
>      the other bindings.
>
> Changes v1 -> v2:
>    * Enable HSDK reset driver in hsdk_defconfig
>
>   arch/arc/boot/dts/hsdk.dts      | 9 +++++++++
>   arch/arc/configs/hsdk_defconfig | 1 +
>   2 files changed, 10 insertions(+)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index b922f3f..8adde1b 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -12,6 +12,7 @@
>   /dts-v1/;
>   
>   #include <dt-bindings/net/ti-dp83867.h>
> +#include <dt-bindings/reset/snps,hsdk-reset.h>
>   
>   / {
>   	model = "snps,hsdk";
> @@ -102,6 +103,12 @@
>   
>   		ranges = <0x00000000 0xf0000000 0x10000000>;
>   
> +		cgu_rst: reset-controller at 8a0 {
> +			compatible = "snps,hsdk-reset";
> +			#reset-cells = <1>;
> +			reg = <0x8A0 0x4>, <0xFF0 0x4>;
> +		};
> +
>   		core_clk: core-clk at 0 {
>   			compatible = "snps,hsdk-core-pll-clock";
>   			reg = <0x00 0x10>, <0x14B8 0x4>;
> @@ -158,6 +165,8 @@
>   			clocks = <&gmacclk>;
>   			clock-names = "stmmaceth";
>   			phy-handle = <&phy0>;
> +			resets = <&cgu_rst HSDK_ETH_RESET>;
> +			reset-names = "stmmaceth";
>   
>   			mdio {
>   				#address-cells = <1>;
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 7b8f8fa..15f0f6b 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -63,6 +63,7 @@ CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_PLTFM=y
>   CONFIG_MMC_DW=y
>   # CONFIG_IOMMU_SUPPORT is not set
> +CONFIG_RESET_HSDK=y

Since we need this feature for our platform, better to just select it in Kconfig.

I can fix it up here if you agree !

-Vineet

>   CONFIG_EXT3_FS=y
>   CONFIG_VFAT_FS=y
>   CONFIG_TMPFS=y

WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	"linux-snps-arc@lists.infradead.org"
	<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3] ARC: [plat-hsdk]: Add reset controller node to manage ethernet reset
Date: Wed, 27 Sep 2017 10:40:20 -0700	[thread overview]
Message-ID: <85347975-edd9-7658-e2cd-7fe1436c77bb@synopsys.com> (raw)
In-Reply-To: <20170922164911.1125-1-Eugeniy.Paltsev@synopsys.com>

On 09/22/2017 09:49 AM, Eugeniy Paltsev wrote:
> DW ethernet controller on HSDK hangs sometimes after SW reset, so
> add reset node to make possible to reset DW ethernet controller HW.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> Changes v2 -> v3:
>    * Remove v1 suffix as we finaly got rid of v1 suffix in reset
>      driver and docs.
>    * Rename reset node to "reset-controller" for consistency with
>      the other bindings.
>
> Changes v1 -> v2:
>    * Enable HSDK reset driver in hsdk_defconfig
>
>   arch/arc/boot/dts/hsdk.dts      | 9 +++++++++
>   arch/arc/configs/hsdk_defconfig | 1 +
>   2 files changed, 10 insertions(+)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index b922f3f..8adde1b 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -12,6 +12,7 @@
>   /dts-v1/;
>   
>   #include <dt-bindings/net/ti-dp83867.h>
> +#include <dt-bindings/reset/snps,hsdk-reset.h>
>   
>   / {
>   	model = "snps,hsdk";
> @@ -102,6 +103,12 @@
>   
>   		ranges = <0x00000000 0xf0000000 0x10000000>;
>   
> +		cgu_rst: reset-controller@8a0 {
> +			compatible = "snps,hsdk-reset";
> +			#reset-cells = <1>;
> +			reg = <0x8A0 0x4>, <0xFF0 0x4>;
> +		};
> +
>   		core_clk: core-clk@0 {
>   			compatible = "snps,hsdk-core-pll-clock";
>   			reg = <0x00 0x10>, <0x14B8 0x4>;
> @@ -158,6 +165,8 @@
>   			clocks = <&gmacclk>;
>   			clock-names = "stmmaceth";
>   			phy-handle = <&phy0>;
> +			resets = <&cgu_rst HSDK_ETH_RESET>;
> +			reset-names = "stmmaceth";
>   
>   			mdio {
>   				#address-cells = <1>;
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 7b8f8fa..15f0f6b 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -63,6 +63,7 @@ CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_PLTFM=y
>   CONFIG_MMC_DW=y
>   # CONFIG_IOMMU_SUPPORT is not set
> +CONFIG_RESET_HSDK=y

Since we need this feature for our platform, better to just select it in Kconfig.

I can fix it up here if you agree !

-Vineet

>   CONFIG_EXT3_FS=y
>   CONFIG_VFAT_FS=y
>   CONFIG_TMPFS=y

  reply	other threads:[~2017-09-27 17:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 16:49 [PATCH v3] ARC: [plat-hsdk]: Add reset controller node to manage ethernet reset Eugeniy Paltsev
2017-09-22 16:49 ` Eugeniy Paltsev
2017-09-27 17:40 ` Vineet Gupta [this message]
2017-09-27 17:40   ` Vineet Gupta
2017-09-27 18:55   ` Eugeniy Paltsev
2017-09-27 18:55     ` Eugeniy Paltsev
2017-09-27 18:55     ` Eugeniy Paltsev
2017-10-05 13:04 ` Vineet Gupta
2017-10-05 13:04   ` Vineet Gupta
2017-10-05 13:04   ` Vineet Gupta
2017-10-05 13:26   ` Eugeniy Paltsev
2017-10-05 13:26     ` Eugeniy Paltsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85347975-edd9-7658-e2cd-7fe1436c77bb@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.