All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: 1579567540@qq.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	David Wu <david.wu@rock-chips.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572
Date: Fri, 13 Nov 2026 09:38:41 +0100	[thread overview]
Message-ID: <85370a77-e2ef-4eae-96f0-7f591625f47d@bootlin.com> (raw)
In-Reply-To: <20261111-add-board-ok3572-c-net-v2-1-304466394970@qq.com>

Hi,

On 11/11/26 10:56, Cunhao Lu via B4 Relay wrote:
> From: Cunhao Lu <1579567540@qq.com>
> 
> Add the rockchip,rk3572-gmac compatible with the snps,dwmac-4.20a
> fallback and require rockchip,php-grf.
> 
> Signed-off-by: Cunhao Lu <1579567540@qq.com>
> ---
> Changes in v2:
> - Add RK3572 to the shared Synopsys compatible list for consistency.

This doesn't address Andrew's request to deprecate the tx_delay and
rx_delay properties for that new SoC. Even if the board you're using
doesn't need them, we need to make sure new designs will use the
generic properties for RGMII delays :)

The older rockchip glues have no choice but to keep accepting these for
compat reasons.

Maxime

pw-bot: cr

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: 1579567540@qq.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	David Wu <david.wu@rock-chips.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572
Date: Fri, 13 Nov 2026 09:38:41 +0100	[thread overview]
Message-ID: <85370a77-e2ef-4eae-96f0-7f591625f47d@bootlin.com> (raw)
In-Reply-To: <20261111-add-board-ok3572-c-net-v2-1-304466394970@qq.com>

Hi,

On 11/11/26 10:56, Cunhao Lu via B4 Relay wrote:
> From: Cunhao Lu <1579567540@qq.com>
> 
> Add the rockchip,rk3572-gmac compatible with the snps,dwmac-4.20a
> fallback and require rockchip,php-grf.
> 
> Signed-off-by: Cunhao Lu <1579567540@qq.com>
> ---
> Changes in v2:
> - Add RK3572 to the shared Synopsys compatible list for consistency.

This doesn't address Andrew's request to deprecate the tx_delay and
rx_delay properties for that new SoC. Even if the board you're using
doesn't need them, we need to make sure new designs will use the
generic properties for RGMII delays :)

The older rockchip glues have no choice but to keep accepting these for
compat reasons.

Maxime

pw-bot: cr

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2026-11-13  8:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  9:56 [PATCH net-next v2 0/2] net: stmmac: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-11  9:56 ` Cunhao Lu
2026-11-11  9:56 ` Cunhao Lu via B4 Relay
2026-11-11  9:56 ` [PATCH net-next v2 1/2] dt-bindings: net: rockchip-dwmac: Add RK3572 Cunhao Lu via B4 Relay
2026-11-11  9:56   ` Cunhao Lu via B4 Relay
2026-11-11  9:56   ` Cunhao Lu
2026-11-11 18:00   ` Conor Dooley
2026-11-11 18:00     ` Conor Dooley
2026-11-13  8:38   ` Maxime Chevallier [this message]
2026-11-13  8:38     ` Maxime Chevallier
2026-11-13  9:19     ` Cunhao Lu
2026-11-13  9:19       ` Cunhao Lu
2026-11-11  9:56 ` [PATCH net-next v2 2/2] net: stmmac: dwmac-rk: Add RK3572 support Cunhao Lu via B4 Relay
2026-11-11  9:56   ` Cunhao Lu
2026-11-11  9:56   ` Cunhao Lu via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85370a77-e2ef-4eae-96f0-7f591625f47d@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=1579567540@qq.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=david.wu@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=heiko@sntech.de \
    --cc=joabreu@synopsys.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.