All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: qcom: sc8280xp-x13s: HBR3 and USB-C DP audio
@ 2026-08-27  7:52 ` Jens Glathe
  0 siblings, 0 replies; 10+ messages in thread
From: Jens Glathe via B4 Relay @ 2026-08-27  7:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Jens Glathe

The X13s already enables both USB-C DisplayPort controllers, but the
board DTS never described the link rates or the audio paths.

Patch 1 lists RBR through HBR3 on the DP0/DP1 outbound endpoints.
Without link-frequencies the msm/dp driver still defaults to HBR2,
which is not enough for some docks and monitors.

Patch 2 adds DP0 and DP1 DAI links on the existing sound card. The
sc8280xp machine driver already handles DISPLAY_PORT_RX_{0,1}, and
the X13s AudioReach topology already has those backends plus the
mixers and routes. The PCM devices were simply never registered.

Dependencies
------------
Depends-on: 20260822-blackrock-audio-3a90de4ac4f9

  [PATCH v2 1/2] arm64: dts: qcom: sc8280xp-microsoft-blackrock: Replace
  old sound nodes, enable DisplayPort audio
  https://lore.kernel.org/all/20260825-blackrock-audio-v2-1-659cc4724d57@oldschoolsolutions.biz/

That series adds the sound-name-prefix properties this card needs so
the two DP codecs do not share widget names. Please apply it first.

Assisted-by: Grok 4.5 (xAI)
Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
Jens Glathe (2):
      arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs
      arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support

 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
---
base-commit: f82a5da2f04960df9fb57489992d03dd5e64ec6f
change-id: 20260827-x13s-dpaudio-19738a5894ac

Best regards,
-- 
Jens Glathe <jens.glathe@oldschoolsolutions.biz>



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 0/2] arm64: dts: qcom: sc8280xp-x13s: HBR3 and USB-C DP audio
@ 2026-08-27  7:52 ` Jens Glathe
  0 siblings, 0 replies; 10+ messages in thread
From: Jens Glathe @ 2026-08-27  7:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Jens Glathe

The X13s already enables both USB-C DisplayPort controllers, but the
board DTS never described the link rates or the audio paths.

Patch 1 lists RBR through HBR3 on the DP0/DP1 outbound endpoints.
Without link-frequencies the msm/dp driver still defaults to HBR2,
which is not enough for some docks and monitors.

Patch 2 adds DP0 and DP1 DAI links on the existing sound card. The
sc8280xp machine driver already handles DISPLAY_PORT_RX_{0,1}, and
the X13s AudioReach topology already has those backends plus the
mixers and routes. The PCM devices were simply never registered.

Dependencies
------------
Depends-on: 20260822-blackrock-audio-3a90de4ac4f9

  [PATCH v2 1/2] arm64: dts: qcom: sc8280xp-microsoft-blackrock: Replace
  old sound nodes, enable DisplayPort audio
  https://lore.kernel.org/all/20260825-blackrock-audio-v2-1-659cc4724d57@oldschoolsolutions.biz/

That series adds the sound-name-prefix properties this card needs so
the two DP codecs do not share widget names. Please apply it first.

Assisted-by: Grok 4.5 (xAI)
Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
Jens Glathe (2):
      arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs
      arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support

 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
---
base-commit: f82a5da2f04960df9fb57489992d03dd5e64ec6f
change-id: 20260827-x13s-dpaudio-19738a5894ac

Best regards,
-- 
Jens Glathe <jens.glathe@oldschoolsolutions.biz>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/2] arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs
  2026-08-27  7:52 ` Jens Glathe
@ 2026-08-27  7:52   ` Jens Glathe
  -1 siblings, 0 replies; 10+ messages in thread
From: Jens Glathe via B4 Relay @ 2026-08-27  7:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Jens Glathe

From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

When no link frequencies are set, the msm/dp driver defaults to HBR2.
Explicitly list the supported rates including HBR3 (8.1 Gbps) on both
USB-C DisplayPort endpoints so high-resolution docks and monitors can
train above 5.4 Gbps.

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 218573a97785b..467e14ca21e56 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -734,6 +734,7 @@ &mdss0_dp0 {
 
 &mdss0_dp0_out {
 	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 	remote-endpoint = <&usb_0_qmpphy_dp_in>;
 };
 
@@ -743,6 +744,7 @@ &mdss0_dp1 {
 
 &mdss0_dp1_out {
 	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 	remote-endpoint = <&usb_1_qmpphy_dp_in>;
 };
 

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/2] arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs
@ 2026-08-27  7:52   ` Jens Glathe
  0 siblings, 0 replies; 10+ messages in thread
From: Jens Glathe @ 2026-08-27  7:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Jens Glathe

When no link frequencies are set, the msm/dp driver defaults to HBR2.
Explicitly list the supported rates including HBR3 (8.1 Gbps) on both
USB-C DisplayPort endpoints so high-resolution docks and monitors can
train above 5.4 Gbps.

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 218573a97785b..467e14ca21e56 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -734,6 +734,7 @@ &mdss0_dp0 {
 
 &mdss0_dp0_out {
 	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 	remote-endpoint = <&usb_0_qmpphy_dp_in>;
 };
 
@@ -743,6 +744,7 @@ &mdss0_dp1 {
 
 &mdss0_dp1_out {
 	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 	remote-endpoint = <&usb_1_qmpphy_dp_in>;
 };
 

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support
  2026-08-27  7:52 ` Jens Glathe
@ 2026-08-27  7:52   ` Jens Glathe
  -1 siblings, 0 replies; 10+ messages in thread
From: Jens Glathe via B4 Relay @ 2026-08-27  7:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Jens Glathe

From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

The X13s sound card has no DAI links for the Type-C DisplayPort
controllers, so those playback paths never show up. Add DP0 and DP1
links using the existing mdss0_dp DAIs and DISPLAY_PORT_RX_{0,1}.

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 467e14ca21e56..bd4b4cb6245cf 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -1215,6 +1215,38 @@ &sound {
 		"VA DMIC2", "MIC BIAS3",
 		"TX SWR_ADC1", "ADC2_OUTPUT";
 
+	dp0-dai-link {
+		link-name = "DP0 Playback";
+
+		codec {
+			sound-dai = <&mdss0_dp0>;
+		};
+
+		cpu {
+			sound-dai = <&q6apmbedai DISPLAY_PORT_RX_0>;
+		};
+
+		platform {
+			sound-dai = <&q6apm>;
+		};
+	};
+
+	dp1-dai-link {
+		link-name = "DP1 Playback";
+
+		codec {
+			sound-dai = <&mdss0_dp1>;
+		};
+
+		cpu {
+			sound-dai = <&q6apmbedai DISPLAY_PORT_RX_1>;
+		};
+
+		platform {
+			sound-dai = <&q6apm>;
+		};
+	};
+
 	wcd-playback-dai-link {
 		link-name = "WCD Playback";
 		cpu {

-- 
2.53.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support
@ 2026-08-27  7:52   ` Jens Glathe
  0 siblings, 0 replies; 10+ messages in thread
From: Jens Glathe @ 2026-08-27  7:52 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Jens Glathe

The X13s sound card has no DAI links for the Type-C DisplayPort
controllers, so those playback paths never show up. Add DP0 and DP1
links using the existing mdss0_dp DAIs and DISPLAY_PORT_RX_{0,1}.

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 467e14ca21e56..bd4b4cb6245cf 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -1215,6 +1215,38 @@ &sound {
 		"VA DMIC2", "MIC BIAS3",
 		"TX SWR_ADC1", "ADC2_OUTPUT";
 
+	dp0-dai-link {
+		link-name = "DP0 Playback";
+
+		codec {
+			sound-dai = <&mdss0_dp0>;
+		};
+
+		cpu {
+			sound-dai = <&q6apmbedai DISPLAY_PORT_RX_0>;
+		};
+
+		platform {
+			sound-dai = <&q6apm>;
+		};
+	};
+
+	dp1-dai-link {
+		link-name = "DP1 Playback";
+
+		codec {
+			sound-dai = <&mdss0_dp1>;
+		};
+
+		cpu {
+			sound-dai = <&q6apmbedai DISPLAY_PORT_RX_1>;
+		};
+
+		platform {
+			sound-dai = <&q6apm>;
+		};
+	};
+
 	wcd-playback-dai-link {
 		link-name = "WCD Playback";
 		cpu {

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support
  2026-08-27  7:52   ` Jens Glathe
  (?)
@ 2026-08-27 11:39   ` Abel Vesa
  -1 siblings, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2026-08-27 11:39 UTC (permalink / raw)
  To: jens.glathe
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On 26-08-27 09:52:49, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> The X13s sound card has no DAI links for the Type-C DisplayPort
> controllers, so those playback paths never show up. Add DP0 and DP1
> links using the existing mdss0_dp DAIs and DISPLAY_PORT_RX_{0,1}.
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs
  2026-08-27  7:52   ` Jens Glathe
  (?)
@ 2026-08-27 11:40   ` Abel Vesa
  -1 siblings, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2026-08-27 11:40 UTC (permalink / raw)
  To: jens.glathe
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On 26-08-27 09:52:48, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> When no link frequencies are set, the msm/dp driver defaults to HBR2.
> Explicitly list the supported rates including HBR3 (8.1 Gbps) on both
> USB-C DisplayPort endpoints so high-resolution docks and monitors can
> train above 5.4 Gbps.
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs
  2026-08-27  7:52   ` Jens Glathe
  (?)
  (?)
@ 2026-08-28 13:15   ` Konrad Dybcio
  -1 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2026-08-28 13:15 UTC (permalink / raw)
  To: jens.glathe, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 8/27/26 9:52 AM, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> When no link frequencies are set, the msm/dp driver defaults to HBR2.
> Explicitly list the supported rates including HBR3 (8.1 Gbps) on both
> USB-C DisplayPort endpoints so high-resolution docks and monitors can
> train above 5.4 Gbps.
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support
  2026-08-27  7:52   ` Jens Glathe
  (?)
  (?)
@ 2026-08-28 13:15   ` Konrad Dybcio
  -1 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2026-08-28 13:15 UTC (permalink / raw)
  To: jens.glathe, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 8/27/26 9:52 AM, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> 
> The X13s sound card has no DAI links for the Type-C DisplayPort
> controllers, so those playback paths never show up. Add DP0 and DP1
> links using the existing mdss0_dp DAIs and DISPLAY_PORT_RX_{0,1}.
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-08-28 13:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-27  7:52 [PATCH 0/2] arm64: dts: qcom: sc8280xp-x13s: HBR3 and USB-C DP audio Jens Glathe via B4 Relay
2026-08-27  7:52 ` Jens Glathe
2026-08-27  7:52 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp-x13s: Enable HBR3 on external DPs Jens Glathe via B4 Relay
2026-08-27  7:52   ` Jens Glathe
2026-08-27 11:40   ` Abel Vesa
2026-08-28 13:15   ` Konrad Dybcio
2026-08-27  7:52 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Add DP0/DP1 audio playback support Jens Glathe via B4 Relay
2026-08-27  7:52   ` Jens Glathe
2026-08-27 11:39   ` Abel Vesa
2026-08-28 13:15   ` Konrad Dybcio

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.