From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unicode: make array 'token' static const, makes object smaller
Date: Mon, 09 Sep 2019 14:21:53 +0000 [thread overview]
Message-ID: <855zm1h7ni.fsf@collabora.com> (raw)
In-Reply-To: <20190906135807.23152-1-colin.king@canonical.com> (Colin King's message of "Fri, 6 Sep 2019 14:58:07 +0100")
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array 'token' on the stack but instead make it
> static const. Makes the object code smaller by 234 bytes.
>
> Before:
> text data bss dec hex filename
> 5371 272 0 5643 160b fs/unicode/utf8-core.o
>
> After:
> text data bss dec hex filename
> 5041 368 0 5409 1521 fs/unicode/utf8-core.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I will get this queued up.
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unicode: make array 'token' static const, makes object smaller
Date: Mon, 09 Sep 2019 10:21:53 -0400 [thread overview]
Message-ID: <855zm1h7ni.fsf@collabora.com> (raw)
In-Reply-To: <20190906135807.23152-1-colin.king@canonical.com> (Colin King's message of "Fri, 6 Sep 2019 14:58:07 +0100")
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array 'token' on the stack but instead make it
> static const. Makes the object code smaller by 234 bytes.
>
> Before:
> text data bss dec hex filename
> 5371 272 0 5643 160b fs/unicode/utf8-core.o
>
> After:
> text data bss dec hex filename
> 5041 368 0 5409 1521 fs/unicode/utf8-core.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I will get this queued up.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2019-09-09 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:58 [PATCH] unicode: make array 'token' static const, makes object smaller Colin King
2019-09-06 13:58 ` Colin King
2019-09-06 15:31 ` Theodore Y. Ts'o
2019-09-06 15:31 ` Theodore Y. Ts'o
2019-09-09 14:21 ` Gabriel Krisman Bertazi [this message]
2019-09-09 14:21 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=855zm1h7ni.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.