From: Roman Mashak <mrv@mojatatu.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action
Date: Tue, 19 Jun 2018 13:15:53 -0400 [thread overview]
Message-ID: <85602eg0ja.fsf@mojatatu.com> (raw)
In-Reply-To: <20180619100408.42155193@xeon-e3> (Stephen Hemminger's message of "Tue, 19 Jun 2018 10:04:08 -0700")
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Tue, 19 Jun 2018 12:56:08 -0400
[...]
>> @@ -326,12 +326,12 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
>> }
>>
>> if (offset % 4) {
>> - pr_info("tc filter pedit offset must be on 32 bit boundaries\n");
>> + pr_info("tc action pedit offset must be on 32 bit boundaries\n");
>> goto bad;
>> }
>>
>> if (!offset_valid(skb, hoffset + offset)) {
>> - pr_info("tc filter pedit offset %d out of bounds\n",
>> + pr_info("tc action pedit offset %d out of bounds\n",
>> hoffset + offset);
>> goto bad;
>
> Time to convert these to netlink extack reporting?
Yes, this is planned in next patches.
next prev parent reply other threads:[~2018-06-19 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:56 [PATCH net 0/5] net sched actions: code style cleanup and fixes Roman Mashak
2018-06-19 16:56 ` [PATCH net 1/5] net sched actions: fix coding style in pedit action Roman Mashak
2018-06-20 12:29 ` Davide Caratti
2018-06-20 13:25 ` Roman Mashak
2018-06-19 16:56 ` [PATCH net 2/5] net sched actions: fix coding style in pedit headers Roman Mashak
2018-06-19 16:56 ` [PATCH net 3/5] net sched actions: fix sparse warning Roman Mashak
2018-06-19 16:56 ` [PATCH net 4/5] net sched actions: use sizeof operator for buffer length Roman Mashak
2018-06-19 16:56 ` [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action Roman Mashak
2018-06-19 17:04 ` Stephen Hemminger
2018-06-19 17:15 ` Roman Mashak [this message]
2018-06-20 8:20 ` [PATCH net 0/5] net sched actions: code style cleanup and fixes Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85602eg0ja.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.