From: Chengming Zhou <chengming.zhou@linux.dev>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
vbabka@suse.cz, roman gushchin <roman.gushchin@linux.dev>,
Xiongwei Song <Xiongwei.Song@windriver.com>
Subject: Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
Date: Mon, 26 Feb 2024 10:46:01 +0800 [thread overview]
Message-ID: <85628515-9b75-4498-8a7f-1f1a33cfeca1@linux.dev> (raw)
In-Reply-To: <1319891481.98257.1708893399313.JavaMail.zimbra@nod.at>
On 2024/2/26 04:36, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "chengming zhou" <chengming.zhou@linux.dev>
>> An: "richard" <richard@nod.at>
>> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-mm"
>> <linux-mm@kvack.org>, vbabka@suse.cz, "roman gushchin" <roman.gushchin@linux.dev>, "Xiongwei Song"
>> <Xiongwei.Song@windriver.com>, "chengming zhou" <chengming.zhou@linux.dev>, "Chengming Zhou"
>> <zhouchengming@bytedance.com>
>> Gesendet: Samstag, 24. Februar 2024 14:52:17
>> Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
>
>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>
> Applied.
> Next time please add a reference that makes very clear why such a flag
> is no longer needed.
> It took me a few minutes to figure why SLAB_MEM_SPREAD is
> now a no-op.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag. And the series[1]
went on to mark it obsolete to avoid confusion for users. Here we
can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
Thanks!
>
> Thanks,
> //richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Chengming Zhou <chengming.zhou@linux.dev>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
vbabka@suse.cz, roman gushchin <roman.gushchin@linux.dev>,
Xiongwei Song <Xiongwei.Song@windriver.com>
Subject: Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
Date: Mon, 26 Feb 2024 10:46:01 +0800 [thread overview]
Message-ID: <85628515-9b75-4498-8a7f-1f1a33cfeca1@linux.dev> (raw)
In-Reply-To: <1319891481.98257.1708893399313.JavaMail.zimbra@nod.at>
On 2024/2/26 04:36, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "chengming zhou" <chengming.zhou@linux.dev>
>> An: "richard" <richard@nod.at>
>> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-mm"
>> <linux-mm@kvack.org>, vbabka@suse.cz, "roman gushchin" <roman.gushchin@linux.dev>, "Xiongwei Song"
>> <Xiongwei.Song@windriver.com>, "chengming zhou" <chengming.zhou@linux.dev>, "Chengming Zhou"
>> <zhouchengming@bytedance.com>
>> Gesendet: Samstag, 24. Februar 2024 14:52:17
>> Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
>
>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>
> Applied.
> Next time please add a reference that makes very clear why such a flag
> is no longer needed.
> It took me a few minutes to figure why SLAB_MEM_SPREAD is
> now a no-op.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag. And the series[1]
went on to mark it obsolete to avoid confusion for users. Here we
can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
Thanks!
>
> Thanks,
> //richard
next prev parent reply other threads:[~2024-02-26 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:52 [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-24 13:52 ` chengming.zhou
2024-02-25 20:36 ` Richard Weinberger
2024-02-25 20:36 ` Richard Weinberger
2024-02-26 2:46 ` Chengming Zhou [this message]
2024-02-26 2:46 ` Chengming Zhou
2024-02-26 2:12 ` Zhihao Cheng
2024-02-26 2:12 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85628515-9b75-4498-8a7f-1f1a33cfeca1@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=Xiongwei.Song@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.