From: "Marc-André Lureau" <mlureau@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>,
claudio fontana <claudio.fontana@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.5 1/5] qemu-doc: Fix ivshmem example markup
Date: Tue, 24 Nov 2015 12:12:31 -0500 (EST) [thread overview]
Message-ID: <856433363.16560463.1448385151683.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1448384789-14830-2-git-send-email-armbru@redhat.com>
----- Original Message -----
> Use @var{foo} like we do everywhere else, not <foo>.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qemu-doc.texi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 460ab71..c9b7069 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -1256,7 +1256,7 @@ zero-copy communication to the application level of the
> guests. The basic
> syntax is:
>
> @example
> -qemu-system-i386 -device ivshmem,size=<size in format accepted by
> -m>[,shm=<shm name>]
> +qemu-system-i386 -device ivshmem,size=@var{size}[,shm=@var{shm-name}]
> @end example
>
> If desired, interrupts can be sent between guest VMs accessing the same
> shared
> @@ -1267,12 +1267,12 @@ memory server is:
>
> @example
> # First start the ivshmem server once and for all
> -ivshmem-server -p <pidfile> -S <path> -m <shm name> -l <shm size> -n
> <vectors n>
> +ivshmem-server -p @var{pidfile} -S @var{path} -m @var{shm-name} -l
> @var{shm-size} -n @var{vectors}
>
> # Then start your qemu instances with matching arguments
> -qemu-system-i386 -device ivshmem,size=<shm size>,vectors=<vectors
> n>,chardev=<id>
> +qemu-system-i386 -device
> ivshmem,size=@var{shm-size},vectors=@var{vectors},chardev=@var{id}
> [,msi=on][,ioeventfd=on][,role=peer|master]
> - -chardev socket,path=<path>,id=<id>
> + -chardev socket,path=@var{path},id=@var{id}
> @end example
>
> When using the server, the guest will be assigned a VM ID (>=0) that allows
> guests
> --
> 2.4.3
>
>
next prev parent reply other threads:[~2015-11-24 17:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 17:06 [Qemu-devel] [PATCH for-2.5 0/5] ivshmem: Last minute changes Markus Armbruster
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 1/5] qemu-doc: Fix ivshmem example markup Markus Armbruster
2015-11-24 17:12 ` Marc-André Lureau [this message]
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 2/5] qemu-doc: Fix ivshmem usage example with shm= Markus Armbruster
2015-11-24 17:14 ` Marc-André Lureau
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device() Markus Armbruster
2015-11-24 17:16 ` Marc-André Lureau
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME Markus Armbruster
2015-11-24 17:17 ` Marc-André Lureau
2015-11-24 17:29 ` Markus Armbruster
2015-11-24 17:42 ` Marc-André Lureau
2015-11-24 18:53 ` Markus Armbruster
2015-11-24 19:52 ` Marc-André Lureau
2015-11-25 8:42 ` Markus Armbruster
2015-11-25 8:46 ` Marc-André Lureau
2015-11-25 9:18 ` Markus Armbruster
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 5/5] ivshmem: Rename property memdev to x-memdev for 2.5 Markus Armbruster
2015-11-24 17:20 ` Marc-André Lureau
2015-11-24 17:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=856433363.16560463.1448385151683.JavaMail.zimbra@redhat.com \
--to=mlureau@redhat.com \
--cc=armbru@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.