All of lore.kernel.org
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Dan Carpenter <dan.carpenter@oracle.com>, David Fries <david@fries.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [patch v2] w1: small type cleanup in sysfs
Date: Fri, 14 Feb 2014 15:42:42 +0000	[thread overview]
Message-ID: <85681392392562@web18h.yandex.ru> (raw)
In-Reply-To: <20140211210755.GA25579@elgon.mountain>

Hi

12.02.2014, 01:08, "Dan Carpenter" <dan.carpenter@oracle.com>:
> On 64 bit systems, a large value for "long tmp" is truncated when
> assigning to "int md->max_slave_count" so we still end up with a value
> less than one despite the "tmp < 1" check.
>
> This is more of a problem for static checkers than a real life issue,
> but it's simple enough to fix.
>
> Acked-by: David Fries <david@fries.net>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Looks good to me, thank you
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Dan Carpenter <dan.carpenter@oracle.com>, David Fries <david@fries.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [patch v2] w1: small type cleanup in sysfs
Date: Fri, 14 Feb 2014 19:42:42 +0400	[thread overview]
Message-ID: <85681392392562@web18h.yandex.ru> (raw)
In-Reply-To: <20140211210755.GA25579@elgon.mountain>

Hi

12.02.2014, 01:08, "Dan Carpenter" <dan.carpenter@oracle.com>:
> On 64 bit systems, a large value for "long tmp" is truncated when
> assigning to "int md->max_slave_count" so we still end up with a value
> less than one despite the "tmp < 1" check.
>
> This is more of a problem for static checkers than a real life issue,
> but it's simple enough to fix.
>
> Acked-by: David Fries <david@fries.net>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Looks good to me, thank you
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

  reply	other threads:[~2014-02-14 15:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 16:08 [patch] w1: small type cleanup in sysfs Dan Carpenter
2014-02-11 16:08 ` Dan Carpenter
2014-02-11 16:45 ` David Fries
2014-02-11 16:45   ` David Fries
2014-02-11 21:07   ` [patch v2] " Dan Carpenter
2014-02-11 21:07     ` Dan Carpenter
2014-02-14 15:42     ` Evgeniy Polyakov [this message]
2014-02-14 15:42       ` Evgeniy Polyakov
2014-02-19  7:19       ` [PATCH] w1: bundle reply if the request was bundled David Fries
2014-02-20 21:07         ` Evgeniy Polyakov
2014-02-11 21:12   ` [patch] w1: small type cleanup in sysfs Dan Carpenter
2014-02-11 21:12     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85681392392562@web18h.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=dan.carpenter@oracle.com \
    --cc=david@fries.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.