From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH v2 07/11] ASoC: SOF: Implement Probe IPC API
Date: Mon, 27 Jan 2020 15:20:05 -0600 [thread overview]
Message-ID: <856e030c-e6ee-75dd-30e2-5ece864ec2fa@linux.intel.com> (raw)
In-Reply-To: <20200127121243.15813-8-cezary.rojewski@intel.com>
> diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h
> index bc2337cf1142..9fa6fb6c7b93 100644
> --- a/sound/soc/sof/sof-priv.h
> +++ b/sound/soc/sof/sof-priv.h
> @@ -387,6 +387,9 @@ struct snd_sof_dev {
> wait_queue_head_t waitq;
> int code_loading;
>
> + /* probes */
> + unsigned int extractor;
> +
if we can rename this extractor_stream_tag it'd be more explicit for
future code evolutions. we have too many things in this sof-dev
structures and it's hard to keep track of what is used for what without
self-explanatory naming conventions. Thanks!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-27 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 12:12 [alsa-devel] [PATCH v2 00/11] ASoC: SOF: Data probing Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 01/11] ALSA: hda: Allow for compress stream to hdac_ext_stream assignment Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 02/11] ALSA: hda: Prepare for compress stream support Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 03/11] ALSA: hda: Interrupt servicing and BDL setup for compress streams Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 04/11] ALSA: core: Expand DMA buffer information Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 05/11] ALSA: core: Implement compress page allocation and free routines Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 06/11] ASoC: SOF: Intel: Account for compress streams when servicing IRQs Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 07/11] ASoC: SOF: Implement Probe IPC API Cezary Rojewski
2020-01-27 20:57 ` Pierre-Louis Bossart
2020-01-28 10:47 ` Cezary Rojewski
2020-01-27 21:01 ` Pierre-Louis Bossart
2020-01-28 10:49 ` Cezary Rojewski
2020-01-27 21:09 ` Pierre-Louis Bossart
2020-01-28 10:50 ` Cezary Rojewski
2020-01-27 21:20 ` Pierre-Louis Bossart [this message]
2020-01-28 10:54 ` Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 08/11] ASoC: SOF: Generic probe compress operations Cezary Rojewski
2020-01-27 21:17 ` Pierre-Louis Bossart
2020-01-28 10:57 ` Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 09/11] ASoC: SOF: Intel: Probe " Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 10/11] ASoC: SOF: Provide probe debugfs support Cezary Rojewski
2020-01-27 12:12 ` [alsa-devel] [PATCH v2 11/11] ASoC: SOF: Intel: Add Probe compress CPU DAIs Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=856e030c-e6ee-75dd-30e2-5ece864ec2fa@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.