From: Marek Vasut <marek.vasut@mailbox.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: David Airlie <airlied@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
"magnus.damm" <magnus.damm@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 4/9] drm/rcar-du: dsi: Clean up CLOCKSET1 CLKINSEL macros
Date: Tue, 23 Sep 2025 11:11:36 +0200 [thread overview]
Message-ID: <856fe0f1-3bf3-4ad2-9e62-a8b1d7dc7eee@mailbox.org> (raw)
In-Reply-To: <TY3PR01MB1134662359F7FADC6919AE0B8861DA@TY3PR01MB11346.jpnprd01.prod.outlook.com>
On 9/23/25 11:04 AM, Biju Das wrote:
Hello Biju,
>>>> -#define CLOCKSET1_CLKINSEL_EXTAL (0 << 2)
>>>
>>> 0
>>>> -#define CLOCKSET1_CLKINSEL_DIG (1 << 2)
>>> 4
>>>> -#define CLOCKSET1_CLKINSEL_DU (1 << 3)
>>> 8
>>>> +#define CLOCKSET1_CLKINSEL_MASK (3 << 2)
>>>> +#define CLOCKSET1_CLKINSEL_EXTAL 0
>>>> +#define CLOCKSET1_CLKINSEL_DIG 1
>>>> +#define CLOCKSET1_CLKINSEL_DU 2
>>>
>>>
>>> Looks like this patch breaks existing functionality,
>>
>> There are no users of this bitfield, hence no updates to the DSI driver.
>> (see commit message). Therefore there is no breakage.
>
> Can we remove it, if there are no users? Or you still prefer to keep it.
The header does contain a complete list of bitfields, that's why I kept it.
next prev parent reply other threads:[~2025-09-23 9:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 18:54 [PATCH 0/9] drm/rcar-du: dsi: Convert register bits to BIT()/GENMASK() macros Marek Vasut
2025-09-22 18:54 ` [PATCH 1/9] drm/rcar-du: dsi: Fix missing parameter in RXSETR_...EN macros Marek Vasut
2025-09-23 11:42 ` Laurent Pinchart
2025-09-22 18:54 ` [PATCH 2/9] drm/rcar-du: dsi: Deduplicate mipi_dsi_pixel_format_to_bpp() usage Marek Vasut
2025-09-23 6:47 ` Geert Uytterhoeven
2025-09-23 8:55 ` Marek Vasut
2025-09-23 8:57 ` Laurent Pinchart
2025-09-23 9:02 ` Geert Uytterhoeven
2025-09-22 18:54 ` [PATCH 3/9] drm/rcar-du: dsi: Clean up VCLKSET register macros Marek Vasut
2025-09-23 9:10 ` kernel test robot
2025-09-23 11:49 ` Laurent Pinchart
2025-09-24 0:00 ` Marek Vasut
2025-09-22 18:55 ` [PATCH 4/9] drm/rcar-du: dsi: Clean up CLOCKSET1 CLKINSEL macros Marek Vasut
2025-09-23 5:45 ` Biju Das
2025-09-23 8:58 ` Marek Vasut
2025-09-23 9:04 ` Biju Das
2025-09-23 9:11 ` Marek Vasut [this message]
2025-09-22 18:55 ` [PATCH 5/9] drm/rcar-du: dsi: Clean up TXVMPSPHSETR DT macros Marek Vasut
2025-09-23 11:52 ` Laurent Pinchart
2025-09-22 18:55 ` [PATCH 6/9] drm/rcar-du: dsi: Respect DSI mode flags Marek Vasut
2025-09-23 11:54 ` Laurent Pinchart
2025-09-22 18:55 ` [PATCH 7/9] drm/rcar-du: dsi: Clean up handling of DRM " Marek Vasut
2025-09-23 13:26 ` Laurent Pinchart
2025-09-24 0:12 ` Marek Vasut
2025-09-24 1:18 ` Sebastian Reichel
2025-09-24 2:36 ` Marek Vasut
2025-09-24 20:53 ` Laurent Pinchart
2025-09-22 18:55 ` [PATCH 8/9] drm/rcar-du: dsi: Convert register bits to BIT() macro Marek Vasut
2025-09-23 14:16 ` Laurent Pinchart
2025-09-24 0:34 ` Marek Vasut
2025-09-22 18:55 ` [PATCH 9/9] drm/rcar-du: dsi: Convert register bitfields to GENMASK() macro Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=856fe0f1-3bf3-4ad2-9e62-a8b1d7dc7eee@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=airlied@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magnus.damm@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.