From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
<intel-xe@lists.freedesktop.org>,
Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>,
Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Riana Tauro <riana.tauro@intel.com>,
"Rodrigo\ Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v6 1/3] drm/xe/pmu: Enable PMU interface
Date: Wed, 13 Nov 2024 20:33:52 -0800 [thread overview]
Message-ID: <85bjyixwlr.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <lnvrm7guru3ujx7kt4irhvjb3wc3vcfzzhko3h5zkvgdig6znm@xb56nnaemwi5>
On Wed, 13 Nov 2024 19:16:55 -0800, Lucas De Marchi wrote:
>
> > diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> > index bccca63c8a48..0cb8d650135a 100644
> > --- a/drivers/gpu/drm/xe/xe_device_types.h
> > +++ b/drivers/gpu/drm/xe/xe_device_types.h
> > @@ -18,6 +18,7 @@
> > #include "xe_memirq_types.h"
> > #include "xe_oa.h"
> > #include "xe_platform_types.h"
> > +#include "xe_pmu.h"
>
> you will need a xe_pmu_types.h where you only define the types.
> See the other lines that serve as good citizens, don't look at xe_oa.h
What's wrong with xe_oa.h :) There's an xe_oa_types.h!
next prev parent reply other threads:[~2024-11-14 4:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 17:42 [PATCH v6 0/3] drm/xe/pmu: PMU interface for Xe Vinay Belgaumkar
2024-11-13 17:42 ` [PATCH v6 1/3] drm/xe/pmu: Enable PMU interface Vinay Belgaumkar
2024-11-14 3:16 ` Lucas De Marchi
2024-11-14 4:33 ` Dixit, Ashutosh [this message]
2024-11-14 15:26 ` Lucas De Marchi
2024-11-14 17:44 ` Belgaumkar, Vinay
2024-11-19 21:08 ` Belgaumkar, Vinay
2024-11-13 17:42 ` [PATCH v6 2/3] drm/xe/pmu: Add GT C6 events Vinay Belgaumkar
2024-11-13 17:42 ` [PATCH v6 3/3] drm/xe/pmu: Add GT frequency events Vinay Belgaumkar
2024-11-13 20:39 ` ✓ CI.Patch_applied: success for drm/xe/pmu: PMU interface for Xe (rev6) Patchwork
2024-11-13 20:40 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-13 20:41 ` ✓ CI.KUnit: success " Patchwork
2024-11-13 20:52 ` ✓ CI.Build: " Patchwork
2024-11-13 20:55 ` ✓ CI.Hooks: " Patchwork
2024-11-13 20:56 ` ✓ CI.checksparse: " Patchwork
2024-11-13 21:17 ` ✓ CI.BAT: " Patchwork
2024-11-14 9:26 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85bjyixwlr.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=krishnaiah.bommu@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.