* [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
@ 2024-05-14 10:52 ` Nikita Shubin via B4 Relay
0 siblings, 0 replies; 4+ messages in thread
From: Nikita Shubin @ 2024-05-14 10:52 UTC (permalink / raw)
To: Vinod Koul, Dave Jiang, Dan Williams
Cc: dmaengine, linux-kernel, Nikita Shubin, Nikita Shubin
Fix missing kmem_cache_destroy() for ioat_sed_cache in
ioat_exit_module().
Noticed via:
```
modprobe ioatdma
rmmod ioatdma
modprobe ioatdma
debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
```
Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
---
drivers/dma/ioat/init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index 9c364e92cb82..61329c279040 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
static void __exit ioat_exit_module(void)
{
pci_unregister_driver(&ioat_pci_driver);
+ kmem_cache_destroy(ioat_sed_cache);
kmem_cache_destroy(ioat_cache);
}
module_exit(ioat_exit_module);
---
base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
change-id: 20240514-ioatdma_fixes-7460f4fd7d51
Best regards,
--
Nikita Shubin <n.shubin@yadro.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
@ 2024-05-14 10:52 ` Nikita Shubin via B4 Relay
0 siblings, 0 replies; 4+ messages in thread
From: Nikita Shubin via B4 Relay @ 2024-05-14 10:52 UTC (permalink / raw)
To: Vinod Koul, Dave Jiang, Dan Williams
Cc: dmaengine, linux-kernel, Nikita Shubin, Nikita Shubin
From: Nikita Shubin <n.shubin@yadro.com>
Fix missing kmem_cache_destroy() for ioat_sed_cache in
ioat_exit_module().
Noticed via:
```
modprobe ioatdma
rmmod ioatdma
modprobe ioatdma
debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
```
Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
---
drivers/dma/ioat/init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index 9c364e92cb82..61329c279040 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
static void __exit ioat_exit_module(void)
{
pci_unregister_driver(&ioat_pci_driver);
+ kmem_cache_destroy(ioat_sed_cache);
kmem_cache_destroy(ioat_cache);
}
module_exit(ioat_exit_module);
---
base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
change-id: 20240514-ioatdma_fixes-7460f4fd7d51
Best regards,
--
Nikita Shubin <n.shubin@yadro.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
2024-05-14 10:52 ` Nikita Shubin via B4 Relay
(?)
@ 2024-05-14 15:38 ` Dave Jiang
-1 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2024-05-14 15:38 UTC (permalink / raw)
To: n.shubin, Vinod Koul, Dan Williams; +Cc: dmaengine, linux-kernel, Nikita Shubin
On 5/14/24 3:52 AM, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <n.shubin@yadro.com>
>
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
>
> Noticed via:
>
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
>
> Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
> Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
Thanks!
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/ioat/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 9c364e92cb82..61329c279040 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
> static void __exit ioat_exit_module(void)
> {
> pci_unregister_driver(&ioat_pci_driver);
> + kmem_cache_destroy(ioat_sed_cache);
> kmem_cache_destroy(ioat_cache);
> }
> module_exit(ioat_exit_module);
>
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240514-ioatdma_fixes-7460f4fd7d51
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
2024-05-14 10:52 ` Nikita Shubin via B4 Relay
(?)
(?)
@ 2024-06-11 18:27 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2024-06-11 18:27 UTC (permalink / raw)
To: Dave Jiang, Dan Williams, Nikita Shubin
Cc: dmaengine, linux-kernel, Nikita Shubin
On Tue, 14 May 2024 13:52:31 +0300, Nikita Shubin wrote:
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
>
> Noticed via:
>
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
>
> [...]
Applied, thanks!
[1/1] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
commit: 5422145d0b749ad554ada772133b9b20f9fb0ec8
Best regards,
--
Vinod Koul <vkoul@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-11 18:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-14 10:52 [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy() Nikita Shubin
2024-05-14 10:52 ` Nikita Shubin via B4 Relay
2024-05-14 15:38 ` Dave Jiang
2024-06-11 18:27 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.