Re: [PATCH 1/2] drm/xe/mcr: Take vcs1/vecs1 into account for first media slice

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 24 Jul 2026 13:11:28 -0700, Ashutosh Dixit wrote:
>
> vcs1 and vecs1 may also be present on the first media slice, so take
> vcs1/vecs1 also into account when determining if the first media slice is
> absent.
>
> Bspec: 77977
>
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_mcr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
> index 9799ffadf85d2..d069d141b54d6 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.c
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
> @@ -454,9 +454,10 @@ static void init_steering_oaddrm(struct xe_gt *gt)
>  {
>	/*
>	 * First instance is only terminated if the entire first media slice
> -	 * is absent (i.e., no VCS0 or VECS0).
> +	 * is absent (i.e., no VCS0, VCS1, VECS0 or VECS1).
>	 */
> -	if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VECS0))
> +	if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VCS1 |
> +				    XE_HW_ENGINE_VECS0 | XE_HW_ENGINE_VECS0))

Sorry, the last term in the above line should be XE_HW_ENGINE_VECS1. I will
fix this up in v2.

>		gt->steering[OADDRM].group_target = 0;
>	else
>		gt->steering[OADDRM].group_target = 1;
> --
> 2.54.0
>