From: Roman Mashak <mrv@mojatatu.com>
To: Petr Machata <petrm@mellanox.com>
Cc: "netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
Ido Schimmel <idosch@mellanox.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [RFC PATCH 10/10] selftests: qdiscs: Add test coverage for ETS Qdisc
Date: Wed, 20 Nov 2019 16:22:15 -0500 [thread overview]
Message-ID: <85d0dmb5vc.fsf@mojatatu.com> (raw)
In-Reply-To: <87o8x6d05t.fsf@mellanox.com> (Petr Machata's message of "Wed, 20 Nov 2019 15:42:40 +0000")
Petr Machata <petrm@mellanox.com> writes:
> Roman Mashak <mrv@mojatatu.com> writes:
>
>> Petr Machata <petrm@mellanox.com> writes:
>>
>>> Add TDC coverage for the new ETS Qdisc.
>>>
>>
>> It would be good to have tests for upper bound limits of qdisc
>> parameters.
>
> All right. I can think of "bands 16", and then "quantum $(((1 << 32) -
> 1))", but I'm not sure the latter is very useful. Did you have anything
> else in mind?
I think, any test that would validate the user's input of parameters
would suffice, e.g. min/max acceptable values, range of values and
such.
next prev parent reply other threads:[~2019-11-20 21:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 13:05 [RFC PATCH 00/10] Add a new Qdisc, ETS Petr Machata
2019-11-20 13:05 ` [RFC PATCH 01/10] net: pkt_cls: Clarify a comment Petr Machata
2019-11-20 13:05 ` [RFC PATCH 02/10] mlxsw: spectrum_qdisc: " Petr Machata
2019-11-20 13:05 ` [RFC PATCH 03/10] mlxsw: spectrum: Fix typos in MLXSW_REG_QEEC_HIERARCHY_* enumerators Petr Machata
2019-11-20 13:05 ` [RFC PATCH 04/10] net: sch_ets: Add a new Qdisc Petr Machata
2019-11-20 13:05 ` [RFC PATCH 05/10] net: sch_ets: Make the ETS qdisc offloadable Petr Machata
2019-11-20 13:05 ` [RFC PATCH 06/10] mlxsw: spectrum_qdisc: Generalize PRIO offload to support ETS Petr Machata
2019-11-20 13:05 ` [RFC PATCH 07/10] mlxsw: spectrum_qdisc: Support offloading of ETS Qdisc Petr Machata
2019-11-20 13:05 ` [RFC PATCH 08/10] selftests: forwarding: Move start_/stop_traffic from mlxsw to lib.sh Petr Machata
2019-11-20 13:05 ` [RFC PATCH 09/10] selftests: forwarding: sch_ets: Add test coverage for ETS Qdisc Petr Machata
2019-11-20 13:05 ` [RFC PATCH 10/10] selftests: qdiscs: " Petr Machata
2019-11-20 15:15 ` Roman Mashak
2019-11-20 15:42 ` Petr Machata
2019-11-20 21:22 ` Roman Mashak [this message]
2019-11-20 13:05 ` [RFC PATCH 1/3] libnetlink: parse_rtattr_nested should allow NLA_F_NESTED flag Petr Machata
2019-11-20 13:05 ` [RFC PATCH 2/3] uapi: Update for the ETS Qdisc Petr Machata
2019-11-20 13:05 ` [RFC PATCH 3/3] tc: Add support for " Petr Machata
2019-11-20 23:25 ` [RFC PATCH 00/10] Add a new Qdisc, ETS Jakub Kicinski
2019-11-21 12:43 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d0dmb5vc.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.